astra
/
doggo
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Correctly print colored text on Windows 

This commit will fix #40.

Replacing os.Stdout with color.Output will fix the problem on Windows's console.

Internally, `color.Output` is same as `colorable.NewColorableStdout()`, according to acd5f3bb28/color.go (L25-L27)

see also: https://godocs.io/github.com/mattn/go-colorable#NewColorableStdout
pull/47/head v0.5.4
Gaeulbyul 2022-07-13 20:09:27 +09:00 committed by Karan Sharma
parent 218eb0233a
commit 2cf9e7bf2c
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/doggo/help.go
View File

@ -100,7 +100,7 @@ func renderCustomHelp() {
// should ideally never happen. // should ideally never happen.
panic(err) panic(err)
} }
err = tmpl.Execute(os.Stdout, helpTmplVars) err = tmpl.Execute(color.Output, helpTmplVars)
if err != nil { if err != nil {
// should ideally never happen. // should ideally never happen.
panic(err) panic(err)

3
internal/app/output.go
View File

@ -3,7 +3,6 @@ package app
import ( import (
"encoding/json" "encoding/json"
"fmt" "fmt"
"os"
"github.com/fatih/color" "github.com/fatih/color"
"github.com/miekg/dns" "github.com/miekg/dns"
@ -45,7 +44,7 @@ func (app *App) outputTerminal(rsp []resolvers.Response) {
} }
// Conditional Time column. // Conditional Time column.
table := tablewriter.NewWriter(os.Stdout) table := tablewriter.NewWriter(color.Output)
header := []string{"Name", "Type", "Class", "TTL", "Address", "Nameserver"} header := []string{"Name", "Type", "Class", "TTL", "Address", "Nameserver"}
if app.QueryFlags.DisplayTimeTaken { if app.QueryFlags.DisplayTimeTaken {
header = append(header, "Time Taken") header = append(header, "Time Taken")