From f1a1e3aae6c6770596dce7054ab0a93a9911e0d3 Mon Sep 17 00:00:00 2001 From: Karan Sharma Date: Sun, 25 Apr 2021 16:13:03 +0530 Subject: [PATCH] refactor: use switch instead of if --- internal/app/nameservers.go | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/internal/app/nameservers.go b/internal/app/nameservers.go index 5f8daae..1754d3a 100644 --- a/internal/app/nameservers.go +++ b/internal/app/nameservers.go @@ -61,7 +61,8 @@ func initNameserver(n string) (models.Nameserver, error) { if err != nil { return ns, err } - if u.Scheme == "sdns" { + switch u.Scheme { + case "sdns": stamp, err := dnsstamps.NewServerStampFromString(n) if err != nil { return ns, err @@ -77,28 +78,28 @@ func initNameserver(n string) (models.Nameserver, error) { default: return ns, fmt.Errorf("unsupported protocol: %v", stamp.Proto.String()) } - } - if u.Scheme == "https" { + + case "https": ns.Type = models.DOHResolver ns.Address = u.String() - } - if u.Scheme == "tls" { + + case "tls": ns.Type = models.DOTResolver if u.Port() == "" { ns.Address = net.JoinHostPort(u.Hostname(), models.DefaultTLSPort) } else { ns.Address = net.JoinHostPort(u.Hostname(), u.Port()) } - } - if u.Scheme == "tcp" { + + case "tcp": ns.Type = models.TCPResolver if u.Port() == "" { ns.Address = net.JoinHostPort(u.Hostname(), models.DefaultTCPPort) } else { ns.Address = net.JoinHostPort(u.Hostname(), u.Port()) } - } - if u.Scheme == "udp" { + + case "udp": ns.Type = models.UDPResolver if u.Port() == "" { ns.Address = net.JoinHostPort(u.Hostname(), models.DefaultUDPPort)