astra/go-mastodon
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix ineffectual assignments

Browse source 
- Don't assign variables we don't end up using
- Added missing error check in test
This commit is contained in:
Christian Muehlhaeuser 2019-08-08 09:21:21 +00:00 • committed by mattn
parent 1ccf66b8b4
commit 1b7f743892
4 changed files with 14 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

10
helper_test.go
View file

@ -12,13 +12,13 @@ const wantBase64 = "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAHEAAABxCAYAAA
func TestBase64EncodeFileName(t *testing.T) {
// Error in os.Open.
uri, err := Base64EncodeFileName("fail")
_, err := Base64EncodeFileName("fail")
if err == nil {
t.Fatalf("should be fail: %v", err)
}
// Success.
uri, err = Base64EncodeFileName("testdata/logo.png")
uri, err := Base64EncodeFileName("testdata/logo.png")
if err != nil {
t.Fatalf("should not be fail: %v", err)
}
@ -29,7 +29,7 @@ func TestBase64EncodeFileName(t *testing.T) {
func TestBase64Encode(t *testing.T) {
// Error in file.Stat.
uri, err := Base64Encode(nil)
_, err := Base64Encode(nil)
if err == nil {
t.Fatalf("should be fail: %v", err)
}
@ -43,7 +43,7 @@ func TestBase64Encode(t *testing.T) {
if err != nil {
t.Fatalf("should not be fail: %v", err)
}
uri, err = Base64Encode(logo)
_, err = Base64Encode(logo)
if err == nil {
t.Fatalf("should be fail: %v", err)
}
@ -53,7 +53,7 @@ func TestBase64Encode(t *testing.T) {
if err != nil {
t.Fatalf("should not be fail: %v", err)
}
uri, err = Base64Encode(logo)
uri, err := Base64Encode(logo)
if err != nil {
t.Fatalf("should not be fail: %v", err)
}