astra/go-mastodon
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix go vet warnings: call to (*T).Fatalf from a non-test goroutine

Browse source 
The goroutine started from test must not call t.Fatal, but t.Error. Adds
a sync.WaitGroup to make sure all goroutines have a chance to report an
error before test stops.
This commit is contained in:
Michal Vyskocil 2022-12-12 22:27:50 +01:00 • committed by mattn
parent ae970802cf
commit 29bb16009b
2 changed files with 29 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
streaming_test.go
View file

@ -7,6 +7,7 @@ import (
"net/http"
"net/http/httptest"
"strings"
"sync"
"testing"
"time"
)
@ -29,11 +30,14 @@ event: delete
data: 1234567
:thump
`, largeContent))
var wg sync.WaitGroup
wg.Add(1)
go func() {
defer wg.Done()
defer close(q)
err := handleReader(q, r)
if err != nil {
t.Fatalf("should not be fail: %v", err)
t.Errorf("should not be fail: %v", err)
}
}()
var passUpdate, passUpdateLarge, passNotification, passDelete, passError bool
@ -69,6 +73,7 @@ data: 1234567
"update: %t, update (large): %t, notification: %t, delete: %t, error: %t",
passUpdate, passUpdateLarge, passNotification, passDelete, passError)
}
wg.Wait()
}
func TestStreaming(t *testing.T) {
@ -148,11 +153,14 @@ func TestDoStreaming(t *testing.T) {
req = req.WithContext(ctx)
q := make(chan Event)
var wg sync.WaitGroup
wg.Add(1)
go func() {
defer wg.Done()
defer close(q)
c.doStreaming(req, q)
if err != nil {
t.Fatalf("should not be fail: %v", err)
t.Errorf("should not be fail: %v", err)
}
}()
var passError bool
@ -167,6 +175,7 @@ func TestDoStreaming(t *testing.T) {
if !passError {
t.Fatalf("have not passed through: error %t", passError)
}
wg.Wait()
}
func TestStreamingUser(t *testing.T) {