Merge pull request #34 from 178inaba/lint

Fix for golint ./... and ineffassign .

accounts_test.go

@@ -193,11 +193,11 @@ func TestGetAccountFollowing(t *testing.T) {
 		ClientSecret: "bar",
 		AccessToken:  "zoo",
 	})
-	fl, err := client.GetAccountFollowing(context.Background(), 123)
+	_, err := client.GetAccountFollowing(context.Background(), 123)
 	if err == nil {
 		t.Fatalf("should be fail: %v", err)
 	}
-	fl, err = client.GetAccountFollowing(context.Background(), 1234567)
+	fl, err := client.GetAccountFollowing(context.Background(), 1234567)
 	if err != nil {
 		t.Fatalf("should not be fail: %v", err)
 	}

cmd/mstdn/cmd_stream.go

@@ -13,6 +13,7 @@ import (
 	"github.com/urfave/cli"
 )
 
+// SimpleJSON is a struct for output JSON for data to be simple used
 type SimpleJSON struct {
 	ID       int64  `json:"id"`
 	Username string `json:"username"`

cmd/mstdn/main.go

@@ -78,7 +78,8 @@ func prompt() (string, string, error) {
 	fmt.Print("Password: ")
 	var password string
 	if readPassword == nil {
-		t, err := tty.Open()
+		var t *tty.TTY
+		t, err = tty.Open()
 		if err != nil {
 			return "", "", err
 		}

mastodon.go

@@ -128,6 +128,9 @@ func (c *Client) doAPI(ctx context.Context, method string, uri string, params in
 		ct = mw.FormDataContentType()
 	} else {
 		req, err = http.NewRequest(method, u.String(), nil)
+		if err != nil {
+			return err
+		}
 	}
 	req = req.WithContext(ctx)
 	req.Header.Set("Authorization", "Bearer "+c.config.AccessToken)

notification.go

@@ -26,7 +26,7 @@ func (c *Client) GetNotifications(ctx context.Context) ([]*Notification, error)
 	return notifications, nil
 }
 
-// GetNotifications return notification.
+// GetNotification return notification.
 func (c *Client) GetNotification(ctx context.Context, id int64) (*Notification, error) {
 	var notification Notification
 	err := c.doAPI(ctx, http.MethodGet, fmt.Sprintf("/api/v1/notifications/%d", id), nil, &notification, nil)

report.go

@@ -24,9 +24,9 @@ func (c *Client) GetReports(ctx context.Context) ([]*Report, error) {
 }
 
 // Report reports the report
-func (c *Client) Report(ctx context.Context, accountId int64, ids []int64, comment string) (*Report, error) {
+func (c *Client) Report(ctx context.Context, accountID int64, ids []int64, comment string) (*Report, error) {
 	params := url.Values{}
-	params.Set("account_id", fmt.Sprint(accountId))
+	params.Set("account_id", fmt.Sprint(accountID))
 	for _, id := range ids {
 		params.Add("status_ids[]", fmt.Sprint(id))
 	}

status.go

@@ -202,7 +202,7 @@ func (c *Client) Search(ctx context.Context, q string, resolve bool) (*Results,
 	return &results, nil
 }
 
-// PostMedia upload a media attachment.
+// UploadMedia upload a media attachment.
 func (c *Client) UploadMedia(ctx context.Context, file string) (*Attachment, error) {
 	var attachment Attachment
 	err := c.doAPI(ctx, http.MethodPost, "/api/v1/media", file, &attachment, nil)