From fe913e01e56f7a0d1105126450f9ffe9a30e774b Mon Sep 17 00:00:00 2001 From: Kaoru HAYAMA Date: Wed, 25 Oct 2017 14:35:34 +0900 Subject: [PATCH] Fix: forgot to (*Client)GetNotification's parameter: int64 -> ID --- notification.go | 4 ++-- notification_test.go | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/notification.go b/notification.go index 155e417..0dfd8f8 100644 --- a/notification.go +++ b/notification.go @@ -27,9 +27,9 @@ func (c *Client) GetNotifications(ctx context.Context, pg *Pagination) ([]*Notif } // GetNotification return notification. -func (c *Client) GetNotification(ctx context.Context, id int64) (*Notification, error) { +func (c *Client) GetNotification(ctx context.Context, id ID) (*Notification, error) { var notification Notification - err := c.doAPI(ctx, http.MethodGet, fmt.Sprintf("/api/v1/notifications/%d", id), nil, ¬ification, nil) + err := c.doAPI(ctx, http.MethodGet, fmt.Sprintf("/api/v1/notifications/%v", id), nil, ¬ification, nil) if err != nil { return nil, err } diff --git a/notification_test.go b/notification_test.go index 414ebff..3329d02 100644 --- a/notification_test.go +++ b/notification_test.go @@ -40,17 +40,17 @@ func TestGetNotifications(t *testing.T) { t.Fatalf("result should be two: %d", len(ns)) } if ns[0].ID != "122" { - t.Fatalf("want %v but %v", 122, ns[0].ID) + t.Fatalf("want %v but %v", "122", ns[0].ID) } if ns[1].ID != "123" { - t.Fatalf("want %v but %v", 123, ns[1].ID) + t.Fatalf("want %v but %v", "123", ns[1].ID) } - n, err := client.GetNotification(context.Background(), 123) + n, err := client.GetNotification(context.Background(), "123") if err != nil { t.Fatalf("should not be fail: %v", err) } if n.ID != "123" { - t.Fatalf("want %v but %v", 123, n.ID) + t.Fatalf("want %v but %v", "123", n.ID) } err = client.ClearNotifications(context.Background()) if err != nil {