feat: check extension to display external images
This commit is contained in:
		
							parent
							
								
									8ba4b72b37
								
							
						
					
					
						commit
						384cabede5
					
				
					 2 changed files with 3 additions and 3 deletions
				
			
		|  | @ -35,7 +35,7 @@ export const formatMessage = (m) => { | ||||||
| }; | }; | ||||||
| 
 | 
 | ||||||
| const imageRegex = /\.(png|jpe?g|gif|webp)$/i; | const imageRegex = /\.(png|jpe?g|gif|webp)$/i; | ||||||
| const isImage = (attachment) => { | export const isImage = (attachment) => { | ||||||
|   if (!attachment) return false; |   if (!attachment) return false; | ||||||
| 
 | 
 | ||||||
|   // if there's a type, only take that into account
 |   // if there's a type, only take that into account
 | ||||||
|  |  | ||||||
|  | @ -27,7 +27,7 @@ import { useOutletContext } from "react-router-dom"; | ||||||
| import { useRemark } from "react-remark"; | import { useRemark } from "react-remark"; | ||||||
| import styled from "@emotion/styled"; | import styled from "@emotion/styled"; | ||||||
| import { formatBytes, formatShortDateTime, maybeActionErrors, openUrl, shortUrl, topicShortUrl, unmatchedTags } from "../app/utils"; | import { formatBytes, formatShortDateTime, maybeActionErrors, openUrl, shortUrl, topicShortUrl, unmatchedTags } from "../app/utils"; | ||||||
| import { formatMessage, formatTitle } from "../app/notificationUtils"; | import { formatMessage, formatTitle, isImage } from "../app/notificationUtils"; | ||||||
| import { LightboxBackdrop, Paragraph, VerticallyCenteredContainer } from "./styles"; | import { LightboxBackdrop, Paragraph, VerticallyCenteredContainer } from "./styles"; | ||||||
| import subscriptionManager from "../app/SubscriptionManager"; | import subscriptionManager from "../app/SubscriptionManager"; | ||||||
| import priority1 from "../img/priority-1.svg"; | import priority1 from "../img/priority-1.svg"; | ||||||
|  | @ -346,7 +346,7 @@ const Attachment = (props) => { | ||||||
|   const { attachment } = props; |   const { attachment } = props; | ||||||
|   const expired = attachment.expires && attachment.expires < Date.now() / 1000; |   const expired = attachment.expires && attachment.expires < Date.now() / 1000; | ||||||
|   const expires = attachment.expires && attachment.expires > Date.now() / 1000; |   const expires = attachment.expires && attachment.expires > Date.now() / 1000; | ||||||
|   const displayableImage = !expired && attachment.type && attachment.type.startsWith("image/"); |   const displayableImage = !expired && isImage(attachment); | ||||||
| 
 | 
 | ||||||
|   // Unexpired image |   // Unexpired image | ||||||
|   if (displayableImage) { |   if (displayableImage) { | ||||||
|  |  | ||||||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue