Use es6 destructuring swap for shuffling

pull/750/head
nimbleghost 2023-05-24 17:49:04 +02:00
parent 9056d68fc9
commit 4d90e32fe9
1 changed files with 7 additions and 10 deletions

View File

@ -139,17 +139,14 @@ export const maybeAppendActionErrors = (message, notification) => {
}; };
export const shuffle = (arr) => { export const shuffle = (arr) => {
let j; const returnArr = [...arr];
let x;
for (let index = arr.length - 1; index > 0; index -= 1) { for (let index = returnArr.length - 1; index > 0; index -= 1) {
j = Math.floor(Math.random() * (index + 1)); const j = Math.floor(Math.random() * (index + 1));
x = arr[index]; [returnArr[index], returnArr[j]] = [returnArr[j], returnArr[index]];
// eslint-disable-next-line no-param-reassign
arr[index] = arr[j];
// eslint-disable-next-line no-param-reassign
arr[j] = x;
} }
return arr;
return returnArr;
}; };
export const splitNoEmpty = (s, delimiter) => export const splitNoEmpty = (s, delimiter) =>