Make manual eslint fixes

These are safe fixes, more complicated fixes can be done separately
(just disabled those errors for now).

- Reorder declarations to fix `no-use-before-define`
- Rename parameters for `no-shadow`
- Remove unused parameters, functions, imports
- Switch from `++` and `—` to `+= 1` and `-= 1` for `no-unary`
- Use object spreading instead of parameter reassignment in auth utils
- Use `window.location` instead of `location` global
- Use inline JSX strings instead of unescaped values
-

web/src/components/SubscriptionPopup.jsx

@@ -241,8 +241,6 @@ const DisplayNameDialog = (props) => {
           inputProps={{
             maxLength: 64,
             "aria-label": t("display_name_dialog_placeholder"),
-          }}
-          InputProps={{
             endAdornment: (
               <InputAdornment position="end">
                 <IconButton onClick={() => setDisplayName("")} edge="end">
@@ -292,20 +290,17 @@ const LimitReachedChip = () => {
   );
 };
 
-export const ProChip = () => {
-  const { t } = useTranslation();
-  return (
-    <Chip
-      label="ntfy Pro"
-      variant="outlined"
-      color="primary"
-      sx={{
-        opacity: 0.8,
-        fontWeight: "bold",
-        borderWidth: "2px",
-        height: "24px",
-        marginLeft: "5px",
-      }}
-    />
-  );
-};
+export const ProChip = () => (
+  <Chip
+    label="ntfy Pro"
+    variant="outlined"
+    color="primary"
+    sx={{
+      opacity: 0.8,
+      fontWeight: "bold",
+      borderWidth: "2px",
+      height: "24px",
+      marginLeft: "5px",
+    }}
+  />
+);