More TODOs, hurray

pull/600/head
binwiederhier 2023-01-21 16:02:56 -05:00
parent 5310b1d48e
commit 5a7cedce95
1 changed files with 39 additions and 27 deletions

View File

@ -35,17 +35,27 @@ import (
) )
/* /*
TODO TODO
races: --
- v.user --> see publishSyncEventAsync() test
payments: UAT results (round 1):
- reconciliation - Security: Account re-creation leads to terrible behavior. Use user ID instead of user name for (a) visitor map, (b) messages.user column, (c) Stripe checkout session
- Account: Changing password should confirm the old password (Thorben)
- Signup: Re-add password confirmation (Thorben & deadcade)
- Reservation: Kill existing subscribers when topic is reserved (deadcade)
- Reservation (UI): Show "This topic is reserved" error message when trying to reserve a reserved topic (Thorben)
- Reservation (UI): Ask for confirmation when removing reservation (deadcade)
delete messages + reserved topics on ResetTier delete attachments in access.go races:
account deletion should delete messages and reservations and attachments - v.user --> see publishSyncEventAsync() test
Limits & rate limiting: payments:
- reconciliation
delete messages + reserved topics on ResetTier delete attachments in access.go
account deletion should delete messages and reservations and attachments
Limits & rate limiting:
rate limiting weirdness. wth is going on? rate limiting weirdness. wth is going on?
bandwidth limit must be in tier bandwidth limit must be in tier
users without tier: should the stats be persisted? are they meaningful? -> test that the visitor is based on the IP address! users without tier: should the stats be persisted? are they meaningful? -> test that the visitor is based on the IP address!
@ -53,21 +63,23 @@ import (
when ResetStats() is run, reset messagesLimiter (and others)? when ResetStats() is run, reset messagesLimiter (and others)?
Delete visitor when tier is changed to refresh rate limiters Delete visitor when tier is changed to refresh rate limiters
Make sure account endpoints make sense for admins Make sure account endpoints make sense for admins
UI:
- reservation icons UI:
- reservation table delete button: dialog "keep or delete messages?" -
- flicker of upgrade banner - reservation icons
- JS constants - reservation table delete button: dialog "keep or delete messages?"
Sync: - flicker of upgrade banner
- JS constants
Sync:
- sync problems with "deleteAfter=0" and "displayName=" - sync problems with "deleteAfter=0" and "displayName="
Tests: Tests:
- Payment endpoints (make mocks) - Payment endpoints (make mocks)
- Message rate limiting and reset tests - Message rate limiting and reset tests
- Bandwidth limit test - Bandwidth limit test
- test that the visitor is based on the IP address when a user has no tier - test that the visitor is based on the IP address when a user has no tier
*/ */
// Server is the main server, providing the UI and API for ntfy // Server is the main server, providing the UI and API for ntfy