astra
/
plc-mirror
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add a check for zero bytes fetched from PDS 

And log additional info when we're failing to extract rev from repo
bytes
main
Max Ignatenko 2024-03-17 17:14:04 +00:00
parent bc895b6425
commit 638bdcf515
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
cmd/record-indexer/workerpool.go
View File

@ -186,6 +186,10 @@ retry:
reposFetched.WithLabelValues(u.String(), "false").Inc() reposFetched.WithLabelValues(u.String(), "false").Inc()
return fmt.Errorf("failed to fetch repo: %w", err) return fmt.Errorf("failed to fetch repo: %w", err)
} }
if len(b) == 0 {
reposFetched.WithLabelValues(u.String(), "false").Inc()
return fmt.Errorf("PDS returned zero bytes")
}
reposFetched.WithLabelValues(u.String(), "true").Inc() reposFetched.WithLabelValues(u.String(), "true").Inc()
if work.Repo.PDS == pds.Unknown { if work.Repo.PDS == pds.Unknown {
@ -201,6 +205,11 @@ retry:
newRev, err := repo.GetRev(ctx, bytes.NewReader(b)) newRev, err := repo.GetRev(ctx, bytes.NewReader(b))
if err != nil { if err != nil {
l := 25
if len(b) < l {
l = len(b)
}
log.Debug().Err(err).Msgf("Total bytes fetched: %d. First few bytes: %q", len(b), string(b[:l]))
return fmt.Errorf("failed to read 'rev' from the fetched repo: %w", err) return fmt.Errorf("failed to read 'rev' from the fetched repo: %w", err)
} }