Fix hashtag search performing account search as well (#13758)
parent
71fce71c94
commit
27ea7c13a5
|
@ -94,7 +94,7 @@ class SearchService < BaseService
|
||||||
end
|
end
|
||||||
|
|
||||||
def account_searchable?
|
def account_searchable?
|
||||||
account_search? && !(@query.include?('@') && @query.include?(' '))
|
account_search? && !(@query.start_with?('#') || (@query.include?('@') && @query.include?(' ')))
|
||||||
end
|
end
|
||||||
|
|
||||||
def hashtag_searchable?
|
def hashtag_searchable?
|
||||||
|
|
|
@ -91,6 +91,14 @@ describe SearchService, type: :service do
|
||||||
expect(Tag).not_to have_received(:search_for)
|
expect(Tag).not_to have_received(:search_for)
|
||||||
expect(results).to eq empty_results
|
expect(results).to eq empty_results
|
||||||
end
|
end
|
||||||
|
it 'does not include account when starts with # character' do
|
||||||
|
query = '#tag'
|
||||||
|
allow(AccountSearchService).to receive(:new)
|
||||||
|
|
||||||
|
results = subject.call(query, nil, 10)
|
||||||
|
expect(AccountSearchService).to_not have_received(:new)
|
||||||
|
expect(results).to eq empty_results
|
||||||
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
Reference in New Issue