dependabot[bot]
628b350516
Bump fog-openstack from 0.3.2 to 0.3.10 ( #22542 )
...
Bumps [fog-openstack](https://github.com/fog/fog-openstack ) from 0.3.2 to 0.3.10.
- [Release notes](https://github.com/fog/fog-openstack/releases )
- [Changelog](https://github.com/fog/fog-openstack/blob/master/CHANGELOG.md )
- [Commits](https://github.com/fog/fog-openstack/compare/v0.3.2...v0.3.10 )
---
updated-dependencies:
- dependency-name: fog-openstack
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-20 19:44:56 +09:00
dependabot[bot]
919747322f
Bump scenic from 1.6.0 to 1.7.0 ( #22258 )
...
Bumps [scenic](https://github.com/scenic-views/scenic ) from 1.6.0 to 1.7.0.
- [Release notes](https://github.com/scenic-views/scenic/releases )
- [Changelog](https://github.com/scenic-views/scenic/blob/main/CHANGELOG.md )
- [Commits](https://github.com/scenic-views/scenic/compare/v1.6.0...v1.7.0 )
---
updated-dependencies:
- dependency-name: scenic
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-20 19:10:09 +09:00
dependabot[bot]
c04b762b9c
Bump http from 5.1.0 to 5.1.1 ( #22515 )
...
Bumps [http](https://github.com/httprb/http ) from 5.1.0 to 5.1.1.
- [Release notes](https://github.com/httprb/http/releases )
- [Changelog](https://github.com/httprb/http/blob/main/CHANGES.md )
- [Commits](https://github.com/httprb/http/compare/v5.1.0...v5.1.1 )
---
updated-dependencies:
- dependency-name: http
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-20 19:09:14 +09:00
dependabot[bot]
ef09016f35
Bump pundit from 2.2.0 to 2.3.0 ( #22516 )
...
Bumps [pundit](https://github.com/varvet/pundit ) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/varvet/pundit/releases )
- [Changelog](https://github.com/varvet/pundit/blob/main/CHANGELOG.md )
- [Commits](https://github.com/varvet/pundit/commits )
---
updated-dependencies:
- dependency-name: pundit
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-20 19:08:53 +09:00
dependabot[bot]
fcaeae7761
Bump fog-core from 2.1.0 to 2.3.0 ( #22521 )
...
Bumps [fog-core](https://github.com/fog/fog-core ) from 2.1.0 to 2.3.0.
- [Release notes](https://github.com/fog/fog-core/releases )
- [Changelog](https://github.com/fog/fog-core/blob/master/changelog.md )
- [Commits](https://github.com/fog/fog-core/compare/v2.1.0...v2.3.0 )
---
updated-dependencies:
- dependency-name: fog-core
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-20 19:08:22 +09:00
dependabot[bot]
6a1d41635b
Bump sass from 1.56.2 to 1.57.0 ( #22519 )
...
Bumps [sass](https://github.com/sass/dart-sass ) from 1.56.2 to 1.57.0.
- [Release notes](https://github.com/sass/dart-sass/releases )
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sass/dart-sass/compare/1.56.2...1.57.0 )
---
updated-dependencies:
- dependency-name: sass
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-20 19:07:56 +09:00
Claire
c1de673060
Fix suspension worker crashing on S3-compatible setups without ACL support ( #22487 )
2022-12-19 17:55:17 +01:00
Kai
2bad619d17
Change HTTP to HTTPS for links in CODE_OF_CONDUCT ( #22465 )
2022-12-19 09:46:22 +09:00
Nick Schonning
06b68490d1
Enable eslint:recommended ruleset ( #22433 )
...
* Enable ESLint recommended ruleset
* Disable failing ESLint recommended rules
* Remove rules shadowed by eslint:recommended
2022-12-19 00:51:37 +09:00
Eugen Rochko
2889c68610
New Crowdin updates ( #22182 )
...
* New translations activerecord.en.yml (Malayalam)
* New translations devise.en.yml (Malayalam)
* New translations doorkeeper.en.yml (Malayalam)
* New translations en.json (Breton)
* New translations simple_form.en.yml (Breton)
* New translations activerecord.en.yml (Breton)
* New translations devise.en.yml (Breton)
* New translations doorkeeper.en.yml (Breton)
* New translations en.json (Bosnian)
* New translations en.json (French, Quebec)
* New translations simple_form.en.yml (French, Quebec)
* New translations activerecord.en.yml (French, Quebec)
* New translations devise.en.yml (French, Quebec)
* New translations doorkeeper.en.yml (French, Quebec)
* New translations en.json (Sinhala)
* New translations simple_form.en.yml (Sinhala)
* New translations activerecord.en.yml (Sinhala)
* New translations devise.en.yml (Sinhala)
* New translations doorkeeper.en.yml (Sinhala)
* New translations en.json (Cornish)
* New translations en.json (Kannada)
* New translations devise.en.yml (Kannada)
* New translations simple_form.en.yml (Scottish Gaelic)
* New translations activerecord.en.yml (Scottish Gaelic)
* New translations devise.en.yml (Scottish Gaelic)
* New translations doorkeeper.en.yml (Scottish Gaelic)
* New translations simple_form.en.yml (Asturian)
* New translations activerecord.en.yml (Asturian)
* New translations devise.en.yml (Asturian)
* New translations simple_form.en.yml (Aragonese)
* New translations activerecord.en.yml (Aragonese)
* New translations devise.en.yml (Aragonese)
* New translations doorkeeper.en.yml (Aragonese)
* New translations simple_form.en.yml (Occitan)
* New translations activerecord.en.yml (Occitan)
* New translations devise.en.yml (Occitan)
* New translations doorkeeper.en.yml (Occitan)
* New translations activerecord.en.yml (Kurmanji (Kurdish))
* New translations doorkeeper.en.yml (Kurmanji (Kurdish))
* New translations simple_form.en.yml (Sorani (Kurdish))
* New translations devise.en.yml (Sorani (Kurdish))
* New translations doorkeeper.en.yml (Sorani (Kurdish))
* New translations en.json (Igbo)
* New translations en.json (Corsican)
* New translations simple_form.en.yml (Corsican)
* New translations activerecord.en.yml (Corsican)
* New translations devise.en.yml (Corsican)
* New translations doorkeeper.en.yml (Corsican)
* New translations en.json (Sardinian)
* New translations simple_form.en.yml (Sardinian)
* New translations activerecord.en.yml (Sardinian)
* New translations devise.en.yml (Sardinian)
* New translations doorkeeper.en.yml (Sardinian)
* New translations en.json (Sanskrit)
* New translations en.json (Kabyle)
* New translations simple_form.en.yml (Kabyle)
* New translations activerecord.en.yml (Kabyle)
* New translations devise.en.yml (Kabyle)
* New translations doorkeeper.en.yml (Kabyle)
* New translations en.json (Ido)
* New translations simple_form.en.yml (Ido)
* New translations activerecord.en.yml (Ido)
* New translations devise.en.yml (Ido)
* New translations doorkeeper.en.yml (Ido)
* New translations en.json (Taigi)
* New translations en.json (Silesian)
* New translations en.json (Standard Moroccan Tamazight)
* New translations simple_form.en.yml (Standard Moroccan Tamazight)
* New translations activerecord.en.yml (Standard Moroccan Tamazight)
* New translations devise.en.yml (Standard Moroccan Tamazight)
* New translations doorkeeper.en.yml (Standard Moroccan Tamazight)
* New translations en.json (Afrikaans)
* New translations en.json (Bulgarian)
* New translations en.json (Catalan)
* New translations en.json (Czech)
* New translations en.json (German)
* New translations en.json (Greek)
* New translations en.json (Frisian)
* New translations en.json (Finnish)
* New translations en.json (Irish)
* New translations en.json (Hungarian)
* New translations en.json (Armenian)
* New translations en.json (Italian)
* New translations en.json (Georgian)
* New translations en.json (Lithuanian)
* New translations en.json (Macedonian)
* New translations en.json (Dutch)
* New translations en.json (Punjabi)
* New translations en.json (Chinese Traditional)
* New translations en.json (Urdu (Pakistan))
* New translations en.json (Vietnamese)
* New translations en.json (Tamil)
* New translations en.json (Bengali)
* New translations en.json (Marathi)
* New translations en.json (Croatian)
* New translations en.json (Kazakh)
* New translations en.json (Latvian)
* New translations en.json (Hindi)
* New translations en.json (Telugu)
* New translations en.json (English, United Kingdom)
* New translations en.json (Burmese)
* New translations en.json (Uyghur)
* New translations en.json (Tatar)
* New translations en.json (Malayalam)
* New translations en.json (Latin)
* New translations en.json (Bosnian)
* New translations en.json (Cornish)
* New translations en.json (Kannada)
* New translations en.json (Asturian)
* New translations en.json (Kurmanji (Kurdish))
* New translations en.json (Sorani (Kurdish))
* New translations en.json (Igbo)
* New translations en.json (Corsican)
* New translations en.json (Sardinian)
* New translations en.json (Sanskrit)
* New translations en.json (Kabyle)
* New translations en.json (Taigi)
* New translations en.json (Silesian)
* New translations en.json (Standard Moroccan Tamazight)
* New translations en.yml (French)
* New translations en.yml (Spanish)
* New translations en.yml (Arabic)
* New translations en.yml (Belarusian)
* New translations en.yml (Catalan)
* New translations en.yml (Czech)
* New translations en.yml (Danish)
* New translations en.yml (German)
* New translations en.yml (Greek)
* New translations en.yml (Frisian)
* New translations en.yml (Basque)
* New translations en.yml (Finnish)
* New translations en.yml (Hungarian)
* New translations en.yml (Italian)
* New translations en.yml (Japanese)
* New translations en.yml (Korean)
* New translations en.yml (Dutch)
* New translations en.yml (Norwegian)
* New translations en.yml (Polish)
* New translations en.yml (Portuguese)
* New translations en.yml (Russian)
* New translations en.yml (Slovak)
* New translations en.yml (Slovenian)
* New translations en.yml (Albanian)
* New translations en.yml (Swedish)
* New translations en.yml (Turkish)
* New translations en.yml (Ukrainian)
* New translations en.yml (Chinese Simplified)
* New translations en.yml (Chinese Traditional)
* New translations en.yml (Vietnamese)
* New translations en.yml (Galician)
* New translations en.yml (Icelandic)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Indonesian)
* New translations en.yml (Persian)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Bengali)
* New translations en.yml (Thai)
* New translations en.yml (Norwegian Nynorsk)
* New translations en.yml (Kazakh)
* New translations en.yml (Estonian)
* New translations en.yml (Latvian)
* New translations en.yml (Malay)
* New translations en.yml (Welsh)
* New translations en.yml (Faroese)
* New translations en.yml (Esperanto)
* New translations en.yml (Chinese Traditional, Hong Kong)
* New translations en.yml (Latin)
* New translations en.yml (French, Quebec)
* New translations en.yml (Sinhala)
* New translations en.yml (Scottish Gaelic)
* New translations en.yml (Aragonese)
* New translations en.yml (Occitan)
* New translations en.yml (Kurmanji (Kurdish))
* New translations en.yml (Sorani (Kurdish))
* New translations en.yml (Scots)
* New translations en.yml (Corsican)
* New translations en.yml (Sardinian)
* New translations en.yml (Ido)
* New translations simple_form.en.yml (Bulgarian)
* New translations simple_form.en.yml (Finnish)
* New translations simple_form.en.yml (Latin)
* New translations simple_form.en.yml (French, Quebec)
* New translations simple_form.en.yml (Kurmanji (Kurdish))
* New translations activerecord.en.yml (Frisian)
* New translations activerecord.en.yml (Latin)
* New translations devise.en.yml (Frisian)
* New translations devise.en.yml (Latin)
* New translations devise.en.yml (Kurmanji (Kurdish))
* New translations doorkeeper.en.yml (Bulgarian)
* New translations doorkeeper.en.yml (Frisian)
* New translations doorkeeper.en.yml (Hungarian)
* New translations doorkeeper.en.yml (Italian)
* New translations doorkeeper.en.yml (Vietnamese)
* New translations doorkeeper.en.yml (Latin)
* New translations en.json (Belarusian)
* New translations en.json (Catalan)
* New translations en.json (Danish)
* New translations en.json (Finnish)
* New translations en.json (Turkish)
* New translations en.yml (Belarusian)
* New translations en.yml (Catalan)
* New translations en.yml (Danish)
* New translations en.yml (Swedish)
* New translations en.yml (Turkish)
* New translations doorkeeper.en.yml (Danish)
* Normalize locale files
* New translations en.json (German)
* New translations en.json (Swedish)
* New translations en.json (Estonian)
* New translations en.json (Latvian)
* New translations en.json (Welsh)
* New translations en.yml (Hungarian)
* New translations en.yml (Polish)
* New translations en.yml (Latvian)
* New translations en.yml (Welsh)
* New translations simple_form.en.yml (Welsh)
* New translations activerecord.en.yml (Welsh)
* New translations devise.en.yml (Welsh)
* New translations doorkeeper.en.yml (Czech)
* New translations doorkeeper.en.yml (Latvian)
* New translations doorkeeper.en.yml (Welsh)
* New translations en.json (Ukrainian)
* New translations en.json (Chinese Traditional)
* New translations en.json (Estonian)
* New translations en.yml (Swedish)
* New translations en.yml (Ukrainian)
* New translations en.yml (Chinese Traditional)
* New translations doorkeeper.en.yml (Italian)
* New translations doorkeeper.en.yml (Swedish)
* New translations doorkeeper.en.yml (Chinese Traditional)
* New translations en.json (Catalan)
* New translations en.json (Slovenian)
* New translations en.json (Faroese)
* New translations en.json (Asturian)
* New translations en.yml (Catalan)
* New translations en.yml (German)
* New translations en.yml (Slovenian)
* New translations en.yml (Faroese)
* New translations doorkeeper.en.yml (German)
* New translations doorkeeper.en.yml (Slovenian)
* New translations doorkeeper.en.yml (Faroese)
* New translations doorkeeper.en.yml (Ukrainian)
* New translations en.json (Greek)
* New translations en.yml (Danish)
* New translations en.json (Danish)
* New translations en.yml (Danish)
* New translations doorkeeper.en.yml (Danish)
* Normalize
Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>
2022-12-16 12:46:39 +09:00
Nick Schonning
3c70f0a9c9
Run Prettier on YML files ( #22345 )
2022-12-16 11:11:52 +09:00
Yamagishi Kazutoshi
f847f67410
Add Western Frisian support ( #18602 )
2022-12-15 19:03:44 +01:00
Claire
d13702ac06
Fix status cache hydration discrepancy ( #19879 )
2022-12-15 18:55:55 +01:00
zunda
10370d316a
Remove packages that are provided by Heroku stacks ( #19836 )
2022-12-15 18:55:29 +01:00
Douglas Blank
2c7df002fa
Add left and right margin to emojis ( #20464 )
2022-12-15 18:53:37 +01:00
Claire
70415714f1
Add follow request banner on account header ( #20785 )
...
* Add requested_by to relationship maps
* Display whether an account has requested to follow you on their profile
2022-12-15 18:50:11 +01:00
Matt Williams
7a3c6bb888
Dont use reserved foldername ( #20582 )
...
Co-authored-by: Effy Elden <effy@effy.space>
2022-12-15 18:49:43 +01:00
Holden Foreman
c761e7a5ef
Fix language surrounding disability in prompts for alt text and other media descriptions ( #20923 )
2022-12-15 18:46:13 +01:00
Jullan-M
b4fe2d1004
Add Southern Sami, and Lule Sami to language list under the ISO-639-3 standard ( #21262 )
...
* Add sme, smj, and sma ISO-639-3 language codes
* Remove sme in ISO-639-3
2022-12-15 18:42:48 +01:00
Christopher Nethercott
c649f4d386
fix: remove SMTP_SERVER ( #21342 )
...
Firstly, mailgun.com is now their domain. Secondly they are lots of providers to use; and sysadmins should be able to choose.
2022-12-15 18:42:08 +01:00
Claire
bf1c7e2122
Ensure exact match is the first result in hashtag searches ( #21315 )
...
Fixes #17494
2022-12-15 18:41:40 +01:00
Bramus!
7fbc17afa2
Fix media markup ( #21420 )
...
This brings the markup of the MediaItem component on par with the Item component from media_gallery.
Co-authored-by: Effy Elden <effy@effy.space>
2022-12-15 18:37:47 +01:00
Shlee
99d2693071
Update circleci ( #21880 )
...
* Update config.yml
* Update config.yml
2022-12-15 18:13:13 +01:00
Claire
2644a28cb3
Change remote media files to be downloaded outside of transactions ( #21796 )
2022-12-15 18:09:48 +01:00
Brian Campbell
2d12948220
Fix idempotency when database writes are slow ( #21840 )
...
There is an idempotency key generated by clients when authoring a post,
and stored in Redis, to ensure that if a user or client retries posting
the same status, we don't get a duplicate.
Hachyderm.io has been experiencing some filesystem and database
performance issues, causing database writes to be slow. This can mean
that there are successful posts, but the reverse proxy returns 504
Gateway Timeout before the idempotency status has been updated; users or
clients who retry (such as Tusky which retries automatically, see
tuskyapp/Tusky#2951 ) can re-try the same post with the same idempotency
key before it has actually been recorded in Redis, leading to duplicate
posts.
To address this issue, move all of the database updates after the
initial transaction that creates the status into the
`postprocess_status!` method, so we can insert the idempotency key
immediately after the status has been created, significantly reducing
the window in which the status could be created but the idempotency key
not yet stored.
Note: this has not yet been tested; I'm submitting this PR for
discussion and to offer to the Hachyderm.io admins to try out to fix the
multiple posting problem.
Co-authored-by: Brian Campbell <brcampbell@beta.team>
2022-12-15 18:08:40 +01:00
Claire
ebf1d74e40
Fix being stuck in edit mode when deleting the edited status ( #22126 )
2022-12-15 17:47:43 +01:00
Claire
8556a649d5
Fix changing domain block severity not undoing individual account effects ( #22135 )
...
* Fix changing domain block severity not undoing individual account effects
Fixes #22133
* Add tests
2022-12-15 17:45:02 +01:00
Effy Elden
1e49be3328
Align everything to Node.js 16 ( #22223 )
...
* Update nvmrc to Node.js 16
* Update package.json minimum Node engine to 16
* Update README requirements to Node.js 16
* Update devcontainer Node.js version to 16
* Update devcontainer Dockerfile Node.js choices to LTS versions that are still in support/maintenance
* Pin CircleCI Node image to 16
* Fix YAML type issue
* Update CircleCI Node.js to 16.18 to match #22019
2022-12-15 17:43:26 +01:00
Claire
fb1d9789db
Fix attachment rendering of edited posts in OpenGraph ( #22270 )
...
Fixes #22241
2022-12-15 17:41:20 +01:00
Avdi Grimm
8a56587d62
Improve devcontainer for running tests ( #22277 )
...
* Improve devcontainer for running tests
- Pull devcontainer post-create out into its own script
- Add asset precompilation
- Add test-mode asset precompilation (needed to run tests without error)
* Document Gemfile.lock re-checkout in devcontainer
2022-12-15 17:40:36 +01:00
Rens Groothuijsen
726c7dea31
Display search popout at fixed screen position ( #16463 )
...
* Display search popout at fixed screen position
* Attach search popout to search box
2022-12-15 17:38:50 +01:00
Terence Eden
ff414a5489
Add transparancy to modal background for accessibility ( #18081 )
...
Fixes #18080
This keeps the `ui-base-lighter-color` but adds enough transparency so that text is more easily readable.
Tested in Firefox and Chrome.
2022-12-15 17:38:35 +01:00
Arnout Engelen
9f63c428e1
Don't autofocus the compose form ( #16517 )
...
When opening a page such as /web/timelines/home in a desktop browser, the
cursor was automatically placed in the textarea of the compose form.
When using the keyboard for navigation (using a browser plugin like vimium or
vim vixen, or just to hit 'space' to scroll down a page), you have remember to
leave the field before using that.
Since you only visit the page to write a new post some of the time, this PR
attempts to have nothing focused initially (and require the user to click or
e.g. use 'tab' to focus the textarea).
Tested:
* /web/timeslines/home no longer autofocuses the compose box
* pressing the 'n' hotkey still focuses the compose box
* clicking 'reply' for a post still focuses the compose box
* replying to a CW'ed post still focuses the compose box
* introducing the CW field still focuses the CW field
* introducing the CW field for a reply still focuses the CW field
* removing the CW field still focuses the compose box
* /web/statuses/new still autofocuses the compose box
fixes #15862
2022-12-15 17:37:05 +01:00
Jeong Arm
3656a6b9cc
Add "disabled" user filter for admin/accounts UI ( #21282 )
2022-12-15 17:30:47 +01:00
Mina Her
cedf138313
Fix margin for search field on medium window size ( #21606 )
2022-12-15 17:24:38 +01:00
David Vega
1b5d207131
Fix single name variables on controller folder ( #20092 )
...
Co-authored-by: petrokoriakin1 <116151189+petrokoriakin1@users.noreply.github.com>
Co-authored-by: petrokoriakin1 <116151189+petrokoriakin1@users.noreply.github.com>
Co-authored-by: Effy Elden <effy@effy.space>
2022-12-15 17:11:58 +01:00
Jeong Arm
d412147d02
Save avatar or header correctly even if other one fails ( #18465 )
...
* Save avatar or header correctly if other one fails
* Fix test
2022-12-15 17:11:14 +01:00
Luxiaba
8f8c0fe88c
Remove inline-css in logo ( #20814 )
2022-12-15 17:10:34 +01:00
Yurii Izorkin
7972e5981c
Add brotli compression ( #19025 )
2022-12-15 17:07:36 +01:00
Matthías Páll Gissurarson
1e95fa3df5
Fix punycoded local domains not being prettified in initial state ( #21440 )
2022-12-15 17:05:40 +01:00
Meisam
059d64a59e
set activation for tag follow button ( #21629 )
...
Co-authored-by: meisam <meisam@noreply.codeberg.org>
2022-12-15 17:04:52 +01:00
Claire
673c54f114
Fix inability to use local LibreTranslate without setting ALLOWED_PRIVATE_ADDRESSES ( #21926 )
...
Fixes #20029
2022-12-15 17:04:38 +01:00
Claire
bbc49f15e0
Add explanation text to log-in page ( #20946 )
2022-12-15 16:44:29 +01:00
Fries
725f21662f
Add Montenegrin (cnr) ( #21013 )
2022-12-15 16:40:57 +01:00
Claire
38596e49d4
Fix the top action bar appearing in multi-column layout ( #20943 )
2022-12-15 16:40:45 +01:00
Claire
623d3d2e32
Change CSP directives on API to be tight and concise ( #20960 )
2022-12-15 16:40:32 +01:00
Kaspar V
19f78ea8fa
linting: RuboCop update, config fixes ( #20574 )
...
* fix(rubocop): update gems and add performance and rspec
fix(rubocop): update gems and add performance and rspec
- update present rubocop gems
- add rubocop-rspec and rubocop-performance gems
- move rubocop gems to gem group :development, :test in order to
make linting in a github action that runs with RAILS_ENV=test possible
* feat(rubocop): disable some annoyance RSpec cops
To mee these prooved to be more annoying than helpful.
If not agreed, they can be enabled any time.
* fix(rubocop): do not ignore spec/**/*
Because rubocop-rspec should lint the specs as well, and they
deserve to be readable in general. It is relevant code, after all.
* fix(rubocop): change ignore db/**/* to db/schema.rb
because rails cops do some lints for migrations.
E.g. reversable migrations linting and more.
* fix(rubocop): tune rules configs
Bunch of commits squashed:
fix(rubocop): enable Layout/LineLength cop
Because this project has code with line lenghts > 500 chars.
This is not good practice at all, so I strongly suggest to
change the practice in the future.
But allow heredoc, URI and comments to still be long lines
and make the default Max: 120 explicit, by repeating it in the
config. To me this max length seems reasonable. Perhaps
a bit more could be ok for some. But > 500 chars in one line
Seems to be way too long IMHO.
fix(rubocop): Metrics/CyclomaticComplexity Max to 12
The default is 7, perhaps quite strict. But 25 is too loose,
the rule becomes pointless like that.
fix(rubocop): AllCops ruby version, cacheing and more info
- fix the target ruby version from 2.5 to 3.0
- have the cop error messages to be more informative and helpful
- enable cacheing in /tmp
fix(rubocop): Metrics/AbcSize to 34 from 115
Rubocops default is 17. If the rule is at 115 is becomes
pointless.
fix(rubocop): Metrics/BlockLength improvements
- instead of ignoring tasks completely, ignore only the
long blocks that are specific to tasks (task, namespace)
- ignore also concern specific block methods (included, class_methods)
fix(rubocop): Metrics/ClassLength count heredoc array as one line
fix(rubocop): Metrics/MethodLength Max to 25
- the default is 10, but 65 is too loose, so perhaps 25?
fix(rubocop): Metrics/ModuleLength array and heredoc count as one
fix(rubocop): Metrics/PerceivedComplexity to 16 from 25
Rubocops default is 8, so how about only doubling that, instead
of > than tripple it?
fix(rubocop): enable Style/RedundantAssignment
Because I think that this rule would never really hurt,
but improve code quality and readability.
fix(rubocop): enable Style/RescueStandardError
I think everyone that ever had to debug what this can bring
will hopefully agree that this rule totally makes sense.
In the super rare exeptions where this is totally needed,
it can be excluded by disabling comment in that place.
fix(rubocop): Metrics/ParameterLists add explicit defaults and some excludes
2022-12-15 16:39:59 +01:00
Neil Matatall
1f5740e65c
Use Rails tag API to build RSS feed for spoilers and polls ( #20163 )
...
* Use Rails tag API to build RSS feed for spoilers and polls
While the previous method did not contain a bug or a potential issue,
the tag API can be very resilient against future problems and reduces the
amount of manual management of the escape status of the content.
I've added tests to ensure that the formatting is broken and still
escapes control characters correctly.
* this seems cleaner and passes
* Incorporate feedback by moving the br to its own line and using the tag helper over the string constant for the br tag itself
* whoops, tag helper doesn't use a self-closing tag
2022-12-15 16:39:41 +01:00
Dan Peterson
3d3429243f
Fix default S3_HOSTNAME used in mastodon:setup ( #19932 )
...
s3-us-east-1.amazonaws.com does not exist.
Co-authored-by: Effy Elden <effy@effy.space>
2022-12-15 16:38:51 +01:00
Colin Mitchell
22e36271c5
Add environment variable to configure sidekiq concurrency ( #19589 )
...
Co-authored-by: Effy Elden <effy@effy.space>
2022-12-15 16:38:37 +01:00
