* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
		
			
				
	
	
		
			156 lines
		
	
	
	
		
			4.4 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			156 lines
		
	
	
	
		
			4.4 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
require 'rails_helper'
 | 
						|
 | 
						|
RSpec.describe Api::V1::StatusesController, type: :controller do
 | 
						|
  render_views
 | 
						|
 | 
						|
  let(:user)  { Fabricate(:user) }
 | 
						|
  let(:app)   { Fabricate(:application, name: 'Test app', website: 'http://testapp.com') }
 | 
						|
  let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, application: app, scopes: scopes) }
 | 
						|
 | 
						|
  context 'with an oauth token' do
 | 
						|
    before do
 | 
						|
      allow(controller).to receive(:doorkeeper_token) { token }
 | 
						|
    end
 | 
						|
 | 
						|
    describe 'GET #show' do
 | 
						|
      let(:scopes) { 'read:statuses' }
 | 
						|
      let(:status) { Fabricate(:status, account: user.account) }
 | 
						|
 | 
						|
      it 'returns http success' do
 | 
						|
        get :show, params: { id: status.id }
 | 
						|
        expect(response).to have_http_status(200)
 | 
						|
      end
 | 
						|
    end
 | 
						|
 | 
						|
    describe 'GET #context' do
 | 
						|
      let(:scopes) { 'read:statuses' }
 | 
						|
      let(:status) { Fabricate(:status, account: user.account) }
 | 
						|
 | 
						|
      before do
 | 
						|
        Fabricate(:status, account: user.account, thread: status)
 | 
						|
      end
 | 
						|
 | 
						|
      it 'returns http success' do
 | 
						|
        get :context, params: { id: status.id }
 | 
						|
        expect(response).to have_http_status(200)
 | 
						|
      end
 | 
						|
    end
 | 
						|
 | 
						|
    describe 'POST #create' do
 | 
						|
      let(:scopes) { 'write:statuses' }
 | 
						|
 | 
						|
      context do
 | 
						|
        before do
 | 
						|
          post :create, params: { status: 'Hello world' }
 | 
						|
        end
 | 
						|
 | 
						|
        it 'returns http success' do
 | 
						|
          expect(response).to have_http_status(200)
 | 
						|
        end
 | 
						|
 | 
						|
        it 'returns rate limit headers' do
 | 
						|
          expect(response.headers['X-RateLimit-Limit']).to eq RateLimiter::FAMILIES[:statuses][:limit].to_s
 | 
						|
          expect(response.headers['X-RateLimit-Remaining']).to eq (RateLimiter::FAMILIES[:statuses][:limit] - 1).to_s
 | 
						|
        end
 | 
						|
      end
 | 
						|
 | 
						|
      context 'with missing parameters' do
 | 
						|
        before do
 | 
						|
          post :create, params: {}
 | 
						|
        end
 | 
						|
 | 
						|
        it 'returns http unprocessable entity' do
 | 
						|
          expect(response).to have_http_status(422)
 | 
						|
        end
 | 
						|
 | 
						|
        it 'returns rate limit headers' do
 | 
						|
          expect(response.headers['X-RateLimit-Limit']).to eq RateLimiter::FAMILIES[:statuses][:limit].to_s
 | 
						|
        end
 | 
						|
      end
 | 
						|
 | 
						|
      context 'when exceeding rate limit' do
 | 
						|
        before do
 | 
						|
          rate_limiter = RateLimiter.new(user.account, family: :statuses)
 | 
						|
          300.times { rate_limiter.record! }
 | 
						|
          post :create, params: { status: 'Hello world' }
 | 
						|
        end
 | 
						|
 | 
						|
        it 'returns http too many requests' do
 | 
						|
          expect(response).to have_http_status(429)
 | 
						|
        end
 | 
						|
 | 
						|
        it 'returns rate limit headers' do
 | 
						|
          expect(response.headers['X-RateLimit-Limit']).to eq RateLimiter::FAMILIES[:statuses][:limit].to_s
 | 
						|
          expect(response.headers['X-RateLimit-Remaining']).to eq '0'
 | 
						|
        end
 | 
						|
      end
 | 
						|
    end
 | 
						|
 | 
						|
    describe 'DELETE #destroy' do
 | 
						|
      let(:scopes) { 'write:statuses' }
 | 
						|
      let(:status) { Fabricate(:status, account: user.account) }
 | 
						|
 | 
						|
      before do
 | 
						|
        post :destroy, params: { id: status.id }
 | 
						|
      end
 | 
						|
 | 
						|
      it 'returns http success' do
 | 
						|
        expect(response).to have_http_status(200)
 | 
						|
      end
 | 
						|
 | 
						|
      it 'removes the status' do
 | 
						|
        expect(Status.find_by(id: status.id)).to be nil
 | 
						|
      end
 | 
						|
    end
 | 
						|
  end
 | 
						|
 | 
						|
  context 'without an oauth token' do
 | 
						|
    before do
 | 
						|
      allow(controller).to receive(:doorkeeper_token) { nil }
 | 
						|
    end
 | 
						|
 | 
						|
    context 'with a private status' do
 | 
						|
      let(:status) { Fabricate(:status, account: user.account, visibility: :private) }
 | 
						|
 | 
						|
      describe 'GET #show' do
 | 
						|
        it 'returns http unautharized' do
 | 
						|
          get :show, params: { id: status.id }
 | 
						|
          expect(response).to have_http_status(404)
 | 
						|
        end
 | 
						|
      end
 | 
						|
 | 
						|
      describe 'GET #context' do
 | 
						|
        before do
 | 
						|
          Fabricate(:status, account: user.account, thread: status)
 | 
						|
        end
 | 
						|
 | 
						|
        it 'returns http unautharized' do
 | 
						|
          get :context, params: { id: status.id }
 | 
						|
          expect(response).to have_http_status(404)
 | 
						|
        end
 | 
						|
      end
 | 
						|
    end
 | 
						|
 | 
						|
    context 'with a public status' do
 | 
						|
      let(:status) { Fabricate(:status, account: user.account, visibility: :public) }
 | 
						|
 | 
						|
      describe 'GET #show' do
 | 
						|
        it 'returns http success' do
 | 
						|
          get :show, params: { id: status.id }
 | 
						|
          expect(response).to have_http_status(200)
 | 
						|
        end
 | 
						|
      end
 | 
						|
 | 
						|
      describe 'GET #context' do
 | 
						|
        before do
 | 
						|
          Fabricate(:status, account: user.account, thread: status)
 | 
						|
        end
 | 
						|
 | 
						|
        it 'returns http success' do
 | 
						|
          get :context, params: { id: status.id }
 | 
						|
          expect(response).to have_http_status(200)
 | 
						|
        end
 | 
						|
      end
 | 
						|
    end
 | 
						|
  end
 | 
						|
end
 |