Remote ActivityPub users that have never been known as OStatus users (whether or not they support it) will not have a “remote_url” attribute set. In case they reside on an instance with WEB_DOMAIN ≠ LOCAL_DOMAIN, the current check did rely on “remote_url” to verify the user's domain.
		
			
				
	
	
		
			45 lines
		
	
	
	
		
			1.4 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			45 lines
		
	
	
	
		
			1.4 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
| # frozen_string_literal: true
 | |
| 
 | |
| class FetchRemoteStatusService < BaseService
 | |
|   include AuthorExtractor
 | |
| 
 | |
|   def call(url, prefetched_body = nil, protocol = :ostatus)
 | |
|     if prefetched_body.nil?
 | |
|       resource_url, resource_options, protocol = FetchAtomService.new.call(url)
 | |
|     else
 | |
|       resource_url     = url
 | |
|       resource_options = { prefetched_body: prefetched_body }
 | |
|     end
 | |
| 
 | |
|     case protocol
 | |
|     when :ostatus
 | |
|       process_atom(resource_url, **resource_options)
 | |
|     when :activitypub
 | |
|       ActivityPub::FetchRemoteStatusService.new.call(resource_url, **resource_options)
 | |
|     end
 | |
|   end
 | |
| 
 | |
|   private
 | |
| 
 | |
|   def process_atom(url, prefetched_body:)
 | |
|     Rails.logger.debug "Processing Atom for remote status at #{url}"
 | |
| 
 | |
|     xml = Nokogiri::XML(prefetched_body)
 | |
|     xml.encoding = 'utf-8'
 | |
| 
 | |
|     account = author_from_xml(xml.at_xpath('/xmlns:entry', xmlns: OStatus::TagManager::XMLNS))
 | |
|     domain  = Addressable::URI.parse(url).normalized_host
 | |
| 
 | |
|     return nil unless !account.nil? && confirmed_domain?(domain, account)
 | |
| 
 | |
|     statuses = ProcessFeedService.new.call(prefetched_body, account)
 | |
|     statuses.first
 | |
|   rescue Nokogiri::XML::XPath::SyntaxError
 | |
|     Rails.logger.debug 'Invalid XML or missing namespace'
 | |
|     nil
 | |
|   end
 | |
| 
 | |
|   def confirmed_domain?(domain, account)
 | |
|     account.domain.nil? || domain.casecmp(account.domain).zero? || domain.casecmp(Addressable::URI.parse(account.remote_url || account.uri).normalized_host).zero?
 | |
|   end
 | |
| end
 |