e38fc319dc
* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
70 lines
1.6 KiB
Ruby
70 lines
1.6 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Api::V1::FollowRequestsController, type: :controller do
|
|
render_views
|
|
|
|
let(:user) { Fabricate(:user, account_attributes: { locked: true }) }
|
|
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: scopes) }
|
|
let(:follower) { Fabricate(:account) }
|
|
|
|
before do
|
|
FollowService.new.call(follower, user.account)
|
|
allow(controller).to receive(:doorkeeper_token) { token }
|
|
end
|
|
|
|
describe 'GET #index' do
|
|
let(:scopes) { 'read:follows' }
|
|
|
|
before do
|
|
get :index, params: { limit: 1 }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
end
|
|
|
|
describe 'POST #authorize' do
|
|
let(:scopes) { 'write:follows' }
|
|
|
|
before do
|
|
post :authorize, params: { id: follower.id }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
|
|
it 'allows follower to follow' do
|
|
expect(follower.following?(user.account)).to be true
|
|
end
|
|
|
|
it 'returns JSON with followed_by=true' do
|
|
json = body_as_json
|
|
|
|
expect(json[:followed_by]).to be true
|
|
end
|
|
end
|
|
|
|
describe 'POST #reject' do
|
|
let(:scopes) { 'write:follows' }
|
|
|
|
before do
|
|
post :reject, params: { id: follower.id }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
|
|
it 'removes follow request' do
|
|
expect(FollowRequest.where(target_account: user.account, account: follower).count).to eq 0
|
|
end
|
|
|
|
it 'returns JSON with followed_by=false' do
|
|
json = body_as_json
|
|
|
|
expect(json[:followed_by]).to be false
|
|
end
|
|
end
|
|
end
|