* Change unapproved and unconfirmed account to not be accessible in the REST API * Change Account#searchable? to reject unconfirmed and unapproved users * Disable search for unapproved and unconfirmed users in Account.search_for * Disable search for unapproved and unconfirmed users in Account.advanced_search_for * Remove unconfirmed and unapproved accounts from Account.searchable scope * Prevent mentions to unapproved/unconfirmed accounts * Fix some old tests for Account.advanced_search_for * Add some Account.advanced_search_for tests for existing behaviors * Add some tests for Account.search_for * Add Account.advanced_search_for tests unconfirmed and unapproved accounts * Add Account.searchable tests * Fix Account.without_unapproved scope potentially messing with previously-applied scopes * Allow lookup of unconfirmed/unapproved accounts through /api/v1/accounts/lookup This is so that the API can still be used to check whether an username is free to use.
		
			
				
	
	
		
			84 lines
		
	
	
	
		
			2.6 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			84 lines
		
	
	
	
		
			2.6 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
| # frozen_string_literal: true
 | |
| 
 | |
| class ProcessMentionsService < BaseService
 | |
|   include Payloadable
 | |
| 
 | |
|   # Scan status for mentions and fetch remote mentioned users, create
 | |
|   # local mention pointers, send Salmon notifications to mentioned
 | |
|   # remote users
 | |
|   # @param [Status] status
 | |
|   def call(status)
 | |
|     @status = status
 | |
| 
 | |
|     return unless @status.local?
 | |
| 
 | |
|     @previous_mentions = @status.active_mentions.includes(:account).to_a
 | |
|     @current_mentions  = []
 | |
| 
 | |
|     Status.transaction do
 | |
|       scan_text!
 | |
|       assign_mentions!
 | |
|     end
 | |
|   end
 | |
| 
 | |
|   private
 | |
| 
 | |
|   def scan_text!
 | |
|     @status.text = @status.text.gsub(Account::MENTION_RE) do |match|
 | |
|       username, domain = Regexp.last_match(1).split('@')
 | |
| 
 | |
|       domain = begin
 | |
|         if TagManager.instance.local_domain?(domain)
 | |
|           nil
 | |
|         else
 | |
|           TagManager.instance.normalize_domain(domain)
 | |
|         end
 | |
|       end
 | |
| 
 | |
|       mentioned_account = Account.find_remote(username, domain)
 | |
| 
 | |
|       # Unapproved and unconfirmed accounts should not be mentionable
 | |
|       next if mentioned_account&.local? && !(mentioned_account.user_confirmed? && mentioned_account.user_approved?)
 | |
| 
 | |
|       # If the account cannot be found or isn't the right protocol,
 | |
|       # first try to resolve it
 | |
|       if mention_undeliverable?(mentioned_account)
 | |
|         begin
 | |
|           mentioned_account = ResolveAccountService.new.call(Regexp.last_match(1))
 | |
|         rescue Webfinger::Error, HTTP::Error, OpenSSL::SSL::SSLError, Mastodon::UnexpectedResponseError
 | |
|           mentioned_account = nil
 | |
|         end
 | |
|       end
 | |
| 
 | |
|       # If after resolving it still isn't found or isn't the right
 | |
|       # protocol, then give up
 | |
|       next match if mention_undeliverable?(mentioned_account) || mentioned_account&.suspended?
 | |
| 
 | |
|       mention   = @previous_mentions.find { |x| x.account_id == mentioned_account.id }
 | |
|       mention ||= mentioned_account.mentions.new(status: @status)
 | |
| 
 | |
|       @current_mentions << mention
 | |
| 
 | |
|       "@#{mentioned_account.acct}"
 | |
|     end
 | |
| 
 | |
|     @status.save!
 | |
|   end
 | |
| 
 | |
|   def assign_mentions!
 | |
|     @current_mentions.each do |mention|
 | |
|       mention.save if mention.new_record?
 | |
|     end
 | |
| 
 | |
|     # If previous mentions are no longer contained in the text, convert them
 | |
|     # to silent mentions, since withdrawing access from someone who already
 | |
|     # received a notification might be more confusing
 | |
|     removed_mentions = @previous_mentions - @current_mentions
 | |
| 
 | |
|     Mention.where(id: removed_mentions.map(&:id)).update_all(silent: true) unless removed_mentions.empty?
 | |
|   end
 | |
| 
 | |
|   def mention_undeliverable?(mentioned_account)
 | |
|     mentioned_account.nil? || (!mentioned_account.local? && !mentioned_account.activitypub?)
 | |
|   end
 | |
| end
 |