Checking reblog vs original status was happening in multiple places across the app. For views, this logic was encapsulated in a helper method named `proper_status` but in the other layers of the app, the logic was duplicated. Because the logic is used at all layers of the app, we extracted it into a `Status#proper` method on the model and changed all uses of the logic to use this method. There is now a single source of truth for this condition. We added test coverage to untested methods that got refactored. |
||
|---|---|---|
| .. | ||
| concerns | ||
| web | ||
| .keep | ||
| account.rb | ||
| application_record.rb | ||
| block.rb | ||
| domain_block.rb | ||
| favourite.rb | ||
| feed.rb | ||
| follow.rb | ||
| follow_request.rb | ||
| import.rb | ||
| media_attachment.rb | ||
| mention.rb | ||
| mute.rb | ||
| notification.rb | ||
| preview_card.rb | ||
| remote_follow.rb | ||
| report.rb | ||
| setting.rb | ||
| status.rb | ||
| stream_entry.rb | ||
| subscription.rb | ||
| tag.rb | ||
| user.rb | ||
| web.rb | ||