* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
		
			
				
	
	
		
			45 lines
		
	
	
	
		
			1.2 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			45 lines
		
	
	
	
		
			1.2 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
| require 'rails_helper'
 | |
| 
 | |
| RSpec.describe Admin::ChangeEmailsController, type: :controller do
 | |
|   render_views
 | |
| 
 | |
|   let(:admin) { Fabricate(:user, admin: true) }
 | |
| 
 | |
|   before do
 | |
|     sign_in admin
 | |
|   end
 | |
| 
 | |
|   describe "GET #show" do
 | |
|     it "returns http success" do
 | |
|       user = Fabricate(:user)
 | |
| 
 | |
|       get :show, params: { account_id: user.account.id }
 | |
| 
 | |
|       expect(response).to have_http_status(200)
 | |
|     end
 | |
|   end
 | |
| 
 | |
|   describe "GET #update" do
 | |
|     before do
 | |
|       allow(UserMailer).to receive(:confirmation_instructions).and_return(double('email', deliver_later: nil))
 | |
|     end
 | |
| 
 | |
|     it "returns http success" do
 | |
|       user = Fabricate(:user)
 | |
| 
 | |
|       previous_email = user.email
 | |
| 
 | |
|       post :update, params: { account_id: user.account.id, user: { unconfirmed_email: 'test@example.com' } }
 | |
| 
 | |
|       user.reload
 | |
| 
 | |
|       expect(user.email).to eq previous_email
 | |
|       expect(user.unconfirmed_email).to eq 'test@example.com'
 | |
|       expect(user.confirmation_token).not_to be_nil
 | |
| 
 | |
|       expect(UserMailer).to have_received(:confirmation_instructions).with(user, user.confirmation_token, { to: 'test@example.com' })
 | |
| 
 | |
|       expect(response).to redirect_to(admin_account_path(user.account.id))
 | |
|     end
 | |
|   end
 | |
| end
 |