* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
		
			
				
	
	
		
			49 lines
		
	
	
	
		
			1.8 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			49 lines
		
	
	
	
		
			1.8 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
require 'rails_helper'
 | 
						|
 | 
						|
RSpec.describe RemoveStatusService, type: :service do
 | 
						|
  subject { RemoveStatusService.new }
 | 
						|
 | 
						|
  let!(:alice)  { Fabricate(:account) }
 | 
						|
  let!(:bob)    { Fabricate(:account, username: 'bob', domain: 'example.com') }
 | 
						|
  let!(:jeff)   { Fabricate(:account) }
 | 
						|
  let!(:hank)   { Fabricate(:account, username: 'hank', protocol: :activitypub, domain: 'example.com', inbox_url: 'http://example.com/inbox') }
 | 
						|
  let!(:bill)   { Fabricate(:account, username: 'bill', protocol: :activitypub, domain: 'example2.com', inbox_url: 'http://example2.com/inbox') }
 | 
						|
 | 
						|
  before do
 | 
						|
    stub_request(:post, 'http://example.com/inbox').to_return(status: 200)
 | 
						|
    stub_request(:post, 'http://example2.com/inbox').to_return(status: 200)
 | 
						|
 | 
						|
    jeff.follow!(alice)
 | 
						|
    hank.follow!(alice)
 | 
						|
 | 
						|
    @status = PostStatusService.new.call(alice, text: 'Hello @bob@example.com')
 | 
						|
    FavouriteService.new.call(jeff, @status)
 | 
						|
    Fabricate(:status, account: bill, reblog: @status, uri: 'hoge')
 | 
						|
  end
 | 
						|
 | 
						|
  it 'removes status from author\'s home feed' do
 | 
						|
    subject.call(@status)
 | 
						|
    expect(HomeFeed.new(alice).get(10)).to_not include(@status.id)
 | 
						|
  end
 | 
						|
 | 
						|
  it 'removes status from local follower\'s home feed' do
 | 
						|
    subject.call(@status)
 | 
						|
    expect(HomeFeed.new(jeff).get(10)).to_not include(@status.id)
 | 
						|
  end
 | 
						|
 | 
						|
  it 'sends delete activity to followers' do
 | 
						|
    subject.call(@status)
 | 
						|
    expect(a_request(:post, 'http://example.com/inbox')).to have_been_made.twice
 | 
						|
  end
 | 
						|
 | 
						|
  it 'sends delete activity to rebloggers' do
 | 
						|
    subject.call(@status)
 | 
						|
    expect(a_request(:post, 'http://example2.com/inbox')).to have_been_made
 | 
						|
  end
 | 
						|
 | 
						|
  it 'remove status from notifications' do
 | 
						|
    expect { subject.call(@status) }.to change {
 | 
						|
      Notification.where(activity_type: 'Favourite', from_account: jeff, account: alice).count
 | 
						|
    }.from(1).to(0)
 | 
						|
  end
 | 
						|
end
 |