From 12a214423293da1914eaae83073e0e3d2c6d1de2 Mon Sep 17 00:00:00 2001
From: Paul Frazee <pfrazee@gmail.com>
Date: Tue, 2 May 2023 23:32:29 -0500
Subject: [PATCH] Remove some confusing horizontal lines in threads (#566)
---
src/state/models/content/post-thread.ts | 4 ++--
src/view/com/post-thread/PostThreadItem.tsx | 10 +++++++++-
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/src/state/models/content/post-thread.ts b/src/state/models/content/post-thread.ts
index 18a42732..a0f75493 100644
--- a/src/state/models/content/post-thread.ts
+++ b/src/state/models/content/post-thread.ts
@@ -125,7 +125,7 @@ export class PostThreadItemModel {
parentModel._depth = this._depth - 1
parentModel._showChildReplyLine = true
if (v.parent.parent) {
- parentModel._showParentReplyLine = true //parentModel.uri !== higlightedPostUri
+ parentModel._showParentReplyLine = true
parentModel.assignTreeModels(v.parent, higlightedPostUri, true, false)
}
this.parent = parentModel
@@ -143,7 +143,7 @@ export class PostThreadItemModel {
const itemModel = new PostThreadItemModel(this.rootStore, item)
itemModel._depth = this._depth + 1
itemModel._showParentReplyLine =
- itemModel.parentUri !== higlightedPostUri
+ itemModel.parentUri !== higlightedPostUri && replies.length === 0
if (item.replies?.length) {
itemModel._showChildReplyLine = true
itemModel.assignTreeModels(item, higlightedPostUri, false, true)
diff --git a/src/view/com/post-thread/PostThreadItem.tsx b/src/view/com/post-thread/PostThreadItem.tsx
index 953e67b1..ddb2cb7b 100644
--- a/src/view/com/post-thread/PostThreadItem.tsx
+++ b/src/view/com/post-thread/PostThreadItem.tsx
@@ -310,7 +310,12 @@ export const PostThreadItem = observer(function PostThreadItem({
<PostHider
testID={`postThreadItem-by-${item.post.author.handle}`}
href={itemHref}
- style={[styles.outer, {borderColor: pal.colors.border}, pal.view]}
+ style={[
+ styles.outer,
+ pal.border,
+ pal.view,
+ item._showParentReplyLine && styles.noTopBorder,
+ ]}
moderation={item.moderation.thread}>
{item._showParentReplyLine && (
<View
@@ -425,6 +430,9 @@ const styles = StyleSheet.create({
paddingLeft: 6,
paddingRight: 6,
},
+ noTopBorder: {
+ borderTopWidth: 0,
+ },
parentReplyLine: {
position: 'absolute',
left: 44,