From 2a5b0ab2acb707a9d87da9e8da403d54734d72e8 Mon Sep 17 00:00:00 2001 From: Hailey Date: Tue, 19 Mar 2024 08:14:29 -0700 Subject: [PATCH] add `Partial` to `.open()` (#3227) --- src/components/Dialog/types.ts | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/components/Dialog/types.ts b/src/components/Dialog/types.ts index 9e7ad3c0..b1a46f85 100644 --- a/src/components/Dialog/types.ts +++ b/src/components/Dialog/types.ts @@ -1,5 +1,5 @@ import React from 'react' -import type {AccessibilityProps} from 'react-native' +import type {AccessibilityProps, GestureResponderEvent} from 'react-native' import {BottomSheetProps} from '@gorhom/bottom-sheet' import {ViewStyleProp} from '#/alf' @@ -10,9 +10,15 @@ type A11yProps = Required * Mutated by useImperativeHandle to provide a public API for controlling the * dialog. The methods here will actually become the handlers defined within * the `Dialog.Outer` component. + * + * `Partial` here allows us to add this directly to the + * `onPress` prop of a button, for example. If this type was not added, we + * would need to create a function to wrap `.open()` with. */ export type DialogControlRefProps = { - open: (options?: DialogControlOpenOptions) => void + open: ( + options?: DialogControlOpenOptions & Partial, + ) => void close: (callback?: () => void) => void }