From 461c1da6de201dbb8fa6c700137e648b33b13c05 Mon Sep 17 00:00:00 2001 From: bnewbold Date: Mon, 28 Aug 2023 19:35:23 -0700 Subject: [PATCH] update golang to v1.21; set GOEXPERIMENT=loopvar (#1256) * golang: update to v1.21, and set GOEXPERIMENT=loopvar * golang: go mod tidy --- .github/workflows/golang-test-lint.yml | 4 ++-- Dockerfile | 3 ++- bskyweb/Makefile | 3 +++ bskyweb/README.md | 2 +- bskyweb/go.mod | 2 +- bskyweb/go.sum | 2 ++ 6 files changed, 11 insertions(+), 5 deletions(-) diff --git a/.github/workflows/golang-test-lint.yml b/.github/workflows/golang-test-lint.yml index 096d1b93..2576c347 100644 --- a/.github/workflows/golang-test-lint.yml +++ b/.github/workflows/golang-test-lint.yml @@ -19,7 +19,7 @@ jobs: - name: Set up Go tooling uses: actions/setup-go@v3 with: - go-version: '1.20' + go-version: '1.21' - name: Dummy JS File run: touch bskyweb/static/js/blah.js - name: Check @@ -36,7 +36,7 @@ jobs: - name: Set up Go tooling uses: actions/setup-go@v3 with: - go-version: '1.20' + go-version: '1.21' - name: Dummy JS File run: touch bskyweb/static/js/blah.js - name: Lint diff --git a/Dockerfile b/Dockerfile index 241926db..388b742c 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM golang:1.20-bullseye AS build-env +FROM golang:1.21-bullseye AS build-env WORKDIR /usr/src/social-app @@ -13,6 +13,7 @@ ENV GODEBUG="netdns=go" ENV GOOS="linux" ENV GOARCH="amd64" ENV CGO_ENABLED=1 +ENV GOEXPERIMENT="loopvar" COPY . . diff --git a/bskyweb/Makefile b/bskyweb/Makefile index 7561a145..e0ba8aec 100644 --- a/bskyweb/Makefile +++ b/bskyweb/Makefile @@ -2,6 +2,9 @@ SHELL = /bin/bash .SHELLFLAGS = -o pipefail -c +# https://github.com/golang/go/wiki/LoopvarExperiment +export GOEXPERIMENT := loopvar + .PHONY: help help: ## Print info about all commands @echo "Commands:" diff --git a/bskyweb/README.md b/bskyweb/README.md index d6064737..c8efe044 100644 --- a/bskyweb/README.md +++ b/bskyweb/README.md @@ -24,7 +24,7 @@ Then build and copy over the big 'ol `bundle.web.js` file: ### Golang Daemon -Install golang. We are generally using v1.20+. +Install golang. We are generally using v1.21+. In this directory (`bskyweb/`): diff --git a/bskyweb/go.mod b/bskyweb/go.mod index 5f06bfc4..bc513727 100644 --- a/bskyweb/go.mod +++ b/bskyweb/go.mod @@ -1,6 +1,6 @@ module github.com/bluesky-social/social-app/bskyweb -go 1.20 +go 1.21 require ( github.com/bluesky-social/indigo v0.0.0-20230504025040-8915cccc3319 diff --git a/bskyweb/go.sum b/bskyweb/go.sum index ae5d7def..a07e446f 100644 --- a/bskyweb/go.sum +++ b/bskyweb/go.sum @@ -31,6 +31,7 @@ github.com/golang-jwt/jwt v3.2.2+incompatible h1:IfV12K8xAKAnZqdXVzCZ+TOjboZ2keL github.com/golang-jwt/jwt v3.2.2+incompatible/go.mod h1:8pz2t5EyA70fFQQSrl6XZXzqecmYZeUEB8OUGHkxJ+I= github.com/google/go-cmp v0.4.0/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE= github.com/google/go-cmp v0.5.9 h1:O2Tfq5qg4qc4AmwVlvv0oLiVAGB7enBSJ2x2DqQFi38= +github.com/google/go-cmp v0.5.9/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY= github.com/google/renameio v0.1.0/go.mod h1:KWCgfxg9yswjAJkECMjeO8J8rahYeXnNhOm40UhjYkI= github.com/google/uuid v1.1.1/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo= github.com/google/uuid v1.3.0 h1:t6JiXgmwXMjEs8VusXIJk2BXHsn+wx8BZdTaoZ5fu7I= @@ -240,6 +241,7 @@ go.uber.org/atomic v1.11.0 h1:ZvwS0R+56ePWxUNi+Atn9dWONBPp/AUETXlHW0DxSjE= go.uber.org/atomic v1.11.0/go.mod h1:LUxbIzbOniOlMKjJjyPfpl4v+PKK2cNJn91OQbhoJI0= go.uber.org/goleak v1.1.11-0.20210813005559-691160354723/go.mod h1:cwTWslyiVhfpKIDGSZEM2HlOvcqm+tG4zioyIeLoqMQ= go.uber.org/goleak v1.1.11 h1:wy28qYRKZgnJTxGxvye5/wgWr1EKjmUDGYox5mGlRlI= +go.uber.org/goleak v1.1.11/go.mod h1:cwTWslyiVhfpKIDGSZEM2HlOvcqm+tG4zioyIeLoqMQ= go.uber.org/multierr v1.5.0/go.mod h1:FeouvMocqHpRaaGuG9EjoKcStLC43Zu/fmqdUMPcKYU= go.uber.org/multierr v1.6.0/go.mod h1:cdWPpRnG4AhwMwsgIHip0KRBQjJy5kYEpYjJxpXp9iU= go.uber.org/multierr v1.11.0 h1:blXXJkSxSSfBVBlC76pxqeO+LN3aDfLQo+309xJstO0=