From 6598fca79d8f1253d6b74c9bbcf24fa384ffaa9b Mon Sep 17 00:00:00 2001 From: Paul Frazee Date: Tue, 3 Oct 2023 19:55:28 -0700 Subject: [PATCH] Fix: only use scroll-positioning control on thread when looking at replies (#1587) --- src/state/models/content/post-thread.ts | 8 ++++++++ src/view/com/post-thread/PostThread.tsx | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/state/models/content/post-thread.ts b/src/state/models/content/post-thread.ts index 981fb1f1..a862c27d 100644 --- a/src/state/models/content/post-thread.ts +++ b/src/state/models/content/post-thread.ts @@ -2,6 +2,7 @@ import {makeAutoObservable, runInAction} from 'mobx' import { AppBskyFeedGetPostThread as GetPostThread, AppBskyFeedDefs, + AppBskyFeedPost, PostModeration, } from '@atproto/api' import {AtUri} from '@atproto/api' @@ -76,6 +77,13 @@ export class PostThreadModel { return this.rootStore.mutedThreads.uris.has(this.rootUri) } + get isCachedPostAReply() { + if (AppBskyFeedPost.isRecord(this.thread?.post.record)) { + return !!this.thread?.post.record.reply + } + return false + } + // public api // = diff --git a/src/view/com/post-thread/PostThread.tsx b/src/view/com/post-thread/PostThread.tsx index 7f6e9ca1..c53c2686 100644 --- a/src/view/com/post-thread/PostThread.tsx +++ b/src/view/com/post-thread/PostThread.tsx @@ -367,7 +367,7 @@ export const PostThread = observer(function PostThread({ data={posts} initialNumToRender={posts.length} maintainVisibleContentPosition={ - isNative && view.isFromCache + isNative && view.isFromCache && view.isCachedPostAReply ? MAINTAIN_VISIBLE_CONTENT_POSITION : undefined }