From 8e2c21a8823b06b408297608d347dd9392d60ee3 Mon Sep 17 00:00:00 2001
From: Hailey <me@haileyok.com>
Date: Thu, 30 May 2024 17:52:56 -0700
Subject: [PATCH] Don't log downsample warning when unnecessary (#4291)

* fix log

use process.env

ensure the log happens regardless of `isDownsampledSession`

fix log

* oops, revert test
---
 src/lib/statsig/statsig.tsx | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/src/lib/statsig/statsig.tsx b/src/lib/statsig/statsig.tsx
index 573a123e..166d468a 100644
--- a/src/lib/statsig/statsig.tsx
+++ b/src/lib/statsig/statsig.tsx
@@ -102,16 +102,19 @@ export function logEvent<E extends keyof LogEvents>(
   rawMetadata: LogEvents[E] & FlatJSONRecord,
 ) {
   try {
+    if (
+      process.env.NODE_ENV === 'development' &&
+      eventName.endsWith(':sampled') &&
+      !DOWNSAMPLED_EVENTS.has(eventName)
+    ) {
+      logger.error(
+        'Did you forget to add ' + eventName + ' to DOWNSAMPLED_EVENTS?',
+      )
+    }
+
     if (isDownsampledSession && DOWNSAMPLED_EVENTS.has(eventName)) {
       return
     }
-    if (process.env.NODE_ENV === 'development') {
-      if (eventName.endsWith(':sampled')) {
-        logger.error(
-          'Did you forget to add ' + eventName + ' to DOWNSAMPLED_EVENTS?',
-        )
-      }
-    }
     const fullMetadata = {
       ...rawMetadata,
     } as Record<string, string> // Statsig typings are unnecessarily strict here.