diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 00000000..c608f660 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,35 @@ +--- +name: Bug report +about: Create a report to help us improve +title: '' +labels: bug +assignees: '' + +--- + +**Describe the bug** + + +**To Reproduce** + +Steps to reproduce the behavior: + +1. + +**Expected behavior** + + + +**Screenshots** + + + +**Details** + + - Platform: + - Platform version: + - App version: + +**Additional context** + + diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md new file mode 100644 index 00000000..0ac6b3c4 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -0,0 +1,24 @@ +--- +name: Feature request +about: Suggest an idea for this project +title: '' +labels: feature-request +assignees: '' + +--- + +**Is your feature request related to a problem? Please describe.** + + + +**Describe the solution you'd like** + + + +**Describe alternatives you've considered** + + + +**Additional context** + + diff --git a/README.md b/README.md index b392579d..449effca 100644 --- a/README.md +++ b/README.md @@ -1,106 +1,67 @@ -# Bluesky +# Bluesky Social App -## Build instructions +Welcome friends! This is the codebase for the Bluesky Social app. It serves as a resource to engineers building on the [AT Protocol](https://atproto.com). -- Setup your environment [using the react native instructions](https://reactnative.dev/docs/environment-setup). -- Setup your environment [for e2e testing using detox](https://wix.github.io/Detox/docs/introduction/getting-started): - - yarn global add detox-cli - - brew tap wix/brew - - brew install applesimutils -- After initial setup: - - `npx expo prebuild` -> you will also need to run this anytime `app.json` or `package.json` changes -- Start the dev servers - - `git clone git@github.com:bluesky-social/atproto.git` - - `cd atproto` - - `yarn` - - `cd packages/dev-env && yarn start` -- Run the dev app - - iOS: `yarn ios` - - Android: `yarn android` - - Web: `yarn web` -- Run e2e tests - - Start in various console tabs: - - `yarn e2e:server` - - `yarn e2e:metro` - - Run once: `yarn e2e:build` - - Each test run: `yarn e2e:run` -- Tips - - `npx react-native info` Checks what has been installed. - - The android simulator won't be able to access localhost services unless you run `adb reverse tcp:{PORT} tcp:{PORT}` - - For instance, the localhosted dev-wallet will need `adb reverse tcp:3001 tcp:3001` - - For some reason, the typescript compiler chokes on platform-specific files (e.g. `foo.native.ts`) but only when compiling for Web thus far. Therefore we always have one version of the file which doesn't use a platform specifier, and that should bee the Web version. ([More info](https://stackoverflow.com/questions/44001050/platform-specific-import-component-in-react-native-with-typescript).) +- **Web: [staging.bsky.app](https://staging.bsky.app)** +- **iOS: [App Store](https://apps.apple.com/us/app/bluesky-social/id6444370199)** +- **Android: [Play Store](https://play.google.com/store/apps/details?id=xyz.blueskyweb.app&hl=en_US&gl=US)** -## Build instructions (with Go) +Links: -### Prerequisites +- [Build instructions](./docs/build.md) +- [ATProto repo](https://github.com/bluesky-social/atproto) +- [ATProto docs](https://atproto.com) -- [Go](https://go.dev/) -- [Yarn](https://yarnpkg.com/) +## Rules & guidelines -### Steps +--- -To run the build with Go, use staging credentials, your own, or any other account you create. +ℹ️ While we do accept contributions, we prioritize high quality issues and pull requests. Adhering to the below guidelines will ensure a more timely review. -``` -cd social-app -yarn && yarn build-web -cp ./web-build/static/js/*.* bskyweb/static/js/ -cd bskyweb/ -go mod tidy -go build -v -tags timetzdata -o bskyweb ./cmd/bskyweb -./bskyweb serve --pds-host=https://staging.bsky.dev --handle= --password= -``` +--- -On build success, access the application at [http://localhost:8100/](http://localhost:8100/). Subsequent changes require re-running the above steps in order to be reflected. +**Rules:** -## Various notes +- We may not respond to your issue or PR. +- We may close an issue or PR without much feedback. +- We may lock discussions or contributions if our attention is getting DDOSed. +- We're not going to provide support for build issues. -### Debugging +**Guidelines:** -- Note that since 0.70, debugging using the old debugger (which shows up using CMD+D) doesn't work anymore. Follow the instructions below to debug the code: https://reactnative.dev/docs/next/hermes#debugging-js-on-hermes-using-google-chromes-devtools +- Check for existing issues before filing a new one please. +- Open an issue and give some time for discussion before submitting a PR. +- Stay away from PRs like... + - Changing "Post" to "Skeet." + - Refactoring the codebase, eg to replace mobx with redux or something. + - Adding entirely new features without prior discussion. -### Developer Menu +Remember, we serve a wide community of users. Our day to day involves us constantly asking "which top priority is our top priority." If you submit well-written PRs that solve problems concisely, that's an awesome contribution. Otherwise, as much as we'd love to accept your ideas and contributions, we really don't have the bandwidth. That's what forking is for! -To open the [Developer Menu](https://docs.expo.dev/debugging/tools/#developer-menu) on an `expo-dev-client` app you can do the following: +## Forking guidelines -- Android Device: Shake the device vertically, or if your device is connected via USB, run adb shell input keyevent 82 in your terminal -- Android Emulator: Either press Cmd ⌘ + m or Ctrl + m or run adb shell input keyevent 82 in your terminal -- iOS Device: Shake the device, or touch 3 fingers to the screen -- iOS Simulator: Press Ctrl + Cmd ⌘ + z on a Mac in the emulator to simulate the shake gesture, or press Cmd ⌘ + d +You have our blessing 🪄✨ to fork this application! However, it's very important to be clear to users when you're giving them a fork. -### Running E2E Tests +Please be sure to: -- Make sure you've setup your environment following above -- Make sure Metro and the dev server are running -- Run `yarn e2e` -- Find the artifacts in the `artifact` folder +- Change all branding in the repository and UI to clearly differentiate from Bluesky. +- Change any support links (feedback, email, terms of service, etc) to your own systems. +- Replace any analytics or error-collection systems with your own so we don't get super confused. -### Polyfills +## Security disclosures -`./platform/polyfills.*.ts` adds polyfills to the environment. Currently this includes: +If you discover any security issues, please send an email to security@bsky.app. The email is automatically CCed to the entire team and we'll respond promptly. -- TextEncoder / TextDecoder +## License (MIT) -### Sentry sourcemaps +Copyright 2023 Bluesky PBLLC -Sourcemaps should automatically be updated when a signed build is created using `eas build` and published using `eas submit` due to the postPublish hook setup in `app.json`. However, if an update is created and published OTA using `eas update`, we need to the take the following steps to upload sourcemaps to Sentry: +Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the “Software”), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: -- Run eas update. This will generate a dist folder in your project root, which contains your JavaScript bundles and source maps. This command will also output the 'Android update ID' and 'iOS update ID' that we'll need in the next step. -- Copy or rename the bundle names in the `dist/bundles` folder to match `index.android.bundle` (Android) or `main.jsbundle` (iOS). -- Next, you can use the Sentry CLI to upload your bundles and source maps: - - release name should be set to `${bundleIdentifier}@${version}+${buildNumber}` (iOS) or `${androidPackage}@${version}+${versionCode}` (Android), so for example `com.domain.myapp@1.0.0+1`. - - `dist` should be set to the Update ID that `eas update` generated. -- Command for Android: - `node_modules/@sentry/cli/bin/sentry-cli releases \ -files \ -upload-sourcemaps \ ---dist \ ---rewrite \ -dist/bundles/index.android.bundle dist/bundles/android-.map` -- Command for iOS: - `node_modules/@sentry/cli/bin/sentry-cli releases \ -files \ -upload-sourcemaps \ ---dist \ ---rewrite \ -dist/bundles/main.jsbundle dist/bundles/ios-.map` +The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED “AS IS”, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. + +## P.S. + +We ❤️ you and all of the ways you support us. Thank you for making Bluesky a great place! diff --git a/docs/build.md b/docs/build.md new file mode 100644 index 00000000..efe24976 --- /dev/null +++ b/docs/build.md @@ -0,0 +1,106 @@ +# Build instructions + +## App Build + +- Setup your environment [using the react native instructions](https://reactnative.dev/docs/environment-setup). +- Setup your environment [for e2e testing using detox](https://wix.github.io/Detox/docs/introduction/getting-started): + - yarn global add detox-cli + - brew tap wix/brew + - brew install applesimutils +- After initial setup: + - `npx expo prebuild` -> you will also need to run this anytime `app.json` or `package.json` changes +- Start the dev servers + - `git clone git@github.com:bluesky-social/atproto.git` + - `cd atproto` + - `yarn` + - `cd packages/dev-env && yarn start` +- Run the dev app + - iOS: `yarn ios` + - Android: `yarn android` + - Web: `yarn web` +- Run e2e tests + - Start in various console tabs: + - `yarn e2e:server` + - `yarn e2e:metro` + - Run once: `yarn e2e:build` + - Each test run: `yarn e2e:run` +- Tips + - `npx react-native info` Checks what has been installed. + - The android simulator won't be able to access localhost services unless you run `adb reverse tcp:{PORT} tcp:{PORT}` + - For instance, the localhosted dev-wallet will need `adb reverse tcp:3001 tcp:3001` + - For some reason, the typescript compiler chokes on platform-specific files (e.g. `foo.native.ts`) but only when compiling for Web thus far. Therefore we always have one version of the file which doesn't use a platform specifier, and that should bee the Web version. ([More info](https://stackoverflow.com/questions/44001050/platform-specific-import-component-in-react-native-with-typescript).) + +## Go-Server Build + +### Prerequisites + +- [Go](https://go.dev/) +- [Yarn](https://yarnpkg.com/) + +### Steps + +To run the build with Go, use staging credentials, your own, or any other account you create. + +``` +cd social-app +yarn && yarn build-web +cp ./web-build/static/js/*.* bskyweb/static/js/ +cd bskyweb/ +go mod tidy +go build -v -tags timetzdata -o bskyweb ./cmd/bskyweb +./bskyweb serve --pds-host=https://staging.bsky.dev --handle= --password= +``` + +On build success, access the application at [http://localhost:8100/](http://localhost:8100/). Subsequent changes require re-running the above steps in order to be reflected. + +## Various notes + +### Debugging + +- Note that since 0.70, debugging using the old debugger (which shows up using CMD+D) doesn't work anymore. Follow the instructions below to debug the code: https://reactnative.dev/docs/next/hermes#debugging-js-on-hermes-using-google-chromes-devtools + +### Developer Menu + +To open the [Developer Menu](https://docs.expo.dev/debugging/tools/#developer-menu) on an `expo-dev-client` app you can do the following: + +- Android Device: Shake the device vertically, or if your device is connected via USB, run adb shell input keyevent 82 in your terminal +- Android Emulator: Either press Cmd ⌘ + m or Ctrl + m or run adb shell input keyevent 82 in your terminal +- iOS Device: Shake the device, or touch 3 fingers to the screen +- iOS Simulator: Press Ctrl + Cmd ⌘ + z on a Mac in the emulator to simulate the shake gesture, or press Cmd ⌘ + d + +### Running E2E Tests + +- Make sure you've setup your environment following above +- Make sure Metro and the dev server are running +- Run `yarn e2e` +- Find the artifacts in the `artifact` folder + +### Polyfills + +`./platform/polyfills.*.ts` adds polyfills to the environment. Currently this includes: + +- TextEncoder / TextDecoder + +### Sentry sourcemaps + +Sourcemaps should automatically be updated when a signed build is created using `eas build` and published using `eas submit` due to the postPublish hook setup in `app.json`. However, if an update is created and published OTA using `eas update`, we need to the take the following steps to upload sourcemaps to Sentry: + +- Run eas update. This will generate a dist folder in your project root, which contains your JavaScript bundles and source maps. This command will also output the 'Android update ID' and 'iOS update ID' that we'll need in the next step. +- Copy or rename the bundle names in the `dist/bundles` folder to match `index.android.bundle` (Android) or `main.jsbundle` (iOS). +- Next, you can use the Sentry CLI to upload your bundles and source maps: + - release name should be set to `${bundleIdentifier}@${version}+${buildNumber}` (iOS) or `${androidPackage}@${version}+${versionCode}` (Android), so for example `com.domain.myapp@1.0.0+1`. + - `dist` should be set to the Update ID that `eas update` generated. +- Command for Android: + `node_modules/@sentry/cli/bin/sentry-cli releases \ +files \ +upload-sourcemaps \ +--dist \ +--rewrite \ +dist/bundles/index.android.bundle dist/bundles/android-.map` +- Command for iOS: + `node_modules/@sentry/cli/bin/sentry-cli releases \ +files \ +upload-sourcemaps \ +--dist \ +--rewrite \ +dist/bundles/main.jsbundle dist/bundles/ios-.map`