From ac976672069e8b5e0cede6591dcf7ce8b9795219 Mon Sep 17 00:00:00 2001 From: Paul Frazee Date: Tue, 13 Dec 2022 15:35:11 -0600 Subject: [PATCH] Fix: avoid duplicate key names in notifications --- src/state/models/notifications-view.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/state/models/notifications-view.ts b/src/state/models/notifications-view.ts index cc895251..fec646b9 100644 --- a/src/state/models/notifications-view.ts +++ b/src/state/models/notifications-view.ts @@ -11,6 +11,8 @@ const UNGROUPABLE_REASONS = ['trend', 'assertion'] const PAGE_SIZE = 30 const MS_60MIN = 1e3 * 60 * 60 +let _idCounter = 0 + export interface GroupedNotification extends ListNotifications.Notification { additional?: ListNotifications.Notification[] } @@ -361,13 +363,12 @@ export class NotificationsViewModel { private async _appendAll(res: ListNotifications.Response, replace = false) { this.loadMoreCursor = res.data.cursor this.hasMore = !!this.loadMoreCursor - let counter = this.notifications.length const promises = [] const itemModels: NotificationsViewItemModel[] = [] for (const item of groupNotifications(res.data.notifications)) { const itemModel = new NotificationsViewItemModel( this.rootStore, - `item-${counter++}`, + `item-${_idCounter++}`, item, ) if (itemModel.needsAdditionalData) {