From c43a0d816000ce732b7b7732de9838ea78599f70 Mon Sep 17 00:00:00 2001
From: Toni Alatalo <toni.alatalo@gmail.com>
Date: Mon, 9 Oct 2023 21:48:57 +0300
Subject: [PATCH 1/4] Typo fix in README.md: "small about" -> "small amount"
(#1639)
---
README.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/README.md b/README.md
index 08e7aba2..d53a3eb2 100644
--- a/README.md
+++ b/README.md
@@ -12,7 +12,7 @@ Get the app itself:
This is a [React Native](https://reactnative.dev/) application, written in the TypeScript programming language. It builds on the `atproto` TypeScript packages (like [`@atproto/api`](https://www.npmjs.com/package/@atproto/api)), code for which is also on open source, but in [a different git repository](https://github.com/bluesky-social/atproto).
-There is a small about of Go language source code (in `./bskyweb/`), for a web service that returns the React Native Web application.
+There is a small amount of Go language source code (in `./bskyweb/`), for a web service that returns the React Native Web application.
The [Build Instructions](./docs/builds.md) are a good place to get started with the app itself.
From d85bbc1a2814d3982b5e23b1ff0790ab6d288b3b Mon Sep 17 00:00:00 2001
From: Raku <42936741+rakutek@users.noreply.github.com>
Date: Tue, 10 Oct 2023 03:55:15 +0900
Subject: [PATCH 2/4] fix typo README.md (#1631)
---
README.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/README.md b/README.md
index d53a3eb2..4f7d00eb 100644
--- a/README.md
+++ b/README.md
@@ -14,7 +14,7 @@ This is a [React Native](https://reactnative.dev/) application, written in the T
There is a small amount of Go language source code (in `./bskyweb/`), for a web service that returns the React Native Web application.
-The [Build Instructions](./docs/builds.md) are a good place to get started with the app itself.
+The [Build Instructions](./docs/build.md) are a good place to get started with the app itself.
The Authenticated Transfer Protocol ("AT Protocol" or "atproto") is a decentralized social media protocol. You don't *need* to understand AT Protocol to work with this application, but it can help. Learn more at:
From b12cfbe90b69d0ec1327c92a1e898be629ebf06b Mon Sep 17 00:00:00 2001
From: Muneyuki Noguchi <nogu.dev@gmail.com>
Date: Tue, 10 Oct 2023 04:29:16 +0900
Subject: [PATCH 3/4] Fix typo in image.ts (#1638)
---
src/state/models/media/image.ts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/state/models/media/image.ts b/src/state/models/media/image.ts
index 10aef0ff..c26f9b87 100644
--- a/src/state/models/media/image.ts
+++ b/src/state/models/media/image.ts
@@ -166,7 +166,7 @@ export class ImageModel implements Omit<RNImage, 'size'> {
async crop() {
try {
// NOTE
- // on ios, react-native-image-cropper gives really bad quality
+ // on ios, react-native-image-crop-picker gives really bad quality
// without specifying width and height. on android, however, the
// crop stretches incorrectly if you do specify it. these are
// both separate bugs in the library. we deal with that by
From ce0f79600870d373bd8289c13f4efb44b253ffb1 Mon Sep 17 00:00:00 2001
From: dan <dan.abramov@gmail.com>
Date: Mon, 9 Oct 2023 22:29:56 +0100
Subject: [PATCH 4/4] Remove unnecessary opacity logic (#1646)
---
src/view/com/lightbox/ImageViewing/index.tsx | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/src/view/com/lightbox/ImageViewing/index.tsx b/src/view/com/lightbox/ImageViewing/index.tsx
index bc2a8a44..b6b321c4 100644
--- a/src/view/com/lightbox/ImageViewing/index.tsx
+++ b/src/view/com/lightbox/ImageViewing/index.tsx
@@ -71,7 +71,6 @@ function ImageViewing({
const imageList = useRef<VirtualizedList<ImageSource>>(null)
const [isScaled, setIsScaled] = useState(false)
const [isDragging, setIsDragging] = useState(false)
- const [opacity, setOpacity] = useState(1)
const [currentImageIndex, setImageIndex] = useState(imageIndex)
const [headerTranslate] = useState(
() => new Animated.ValueXY(INITIAL_POSITION),
@@ -100,12 +99,6 @@ function ImageViewing({
}
}
- const onRequestCloseEnhanced = () => {
- setOpacity(0)
- onRequestClose()
- setTimeout(() => setOpacity(1), 0)
- }
-
const onScroll = (event: NativeSyntheticEvent<NativeScrollEvent>) => {
const {
nativeEvent: {
@@ -162,14 +155,14 @@ function ImageViewing({
aria-modal
accessibilityViewIsModal>
<ModalsContainer />
- <View style={[styles.container, {opacity, backgroundColor}]}>
+ <View style={[styles.container, {backgroundColor}]}>
<Animated.View style={[styles.header, {transform: headerTransform}]}>
{typeof HeaderComponent !== 'undefined' ? (
React.createElement(HeaderComponent, {
imageIndex: currentImageIndex,
})
) : (
- <ImageDefaultHeader onRequestClose={onRequestCloseEnhanced} />
+ <ImageDefaultHeader onRequestClose={onRequestClose} />
)}
</Animated.View>
<VirtualizedList
@@ -191,7 +184,7 @@ function ImageViewing({
<ImageItem
onZoom={onZoom}
imageSrc={imageSrc}
- onRequestClose={onRequestCloseEnhanced}
+ onRequestClose={onRequestClose}
pinchGestureRef={pinchGestureRefs.get(imageSrc)}
isScrollViewBeingDragged={isDragging}
/>