From cd43adf698bbe01d9dd1cd873aa16589e480b88c Mon Sep 17 00:00:00 2001 From: Paul Frazee Date: Mon, 27 Nov 2023 12:30:41 -0800 Subject: [PATCH] Two fixes to react-key generation (#2004) * Fix missing react keys in ListMembers * Fix react key construction for the posts feed --- src/lib/api/feed-manip.ts | 5 +++-- src/view/com/lists/ListMembers.tsx | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/lib/api/feed-manip.ts b/src/lib/api/feed-manip.ts index 7dfc9258..912302d0 100644 --- a/src/lib/api/feed-manip.ts +++ b/src/lib/api/feed-manip.ts @@ -19,8 +19,9 @@ export class FeedViewPostsSlice { constructor(public items: FeedViewPost[] = []) {} get _reactKey() { - return `slice-${this.items[0].post.uri}-${ - this.items[0].reason?.indexedAt || this.items[0].post.indexedAt + const rootItem = this.isFlattenedReply ? this.items[1] : this.items[0] + return `slice-${rootItem.post.uri}-${ + rootItem.reason?.indexedAt || rootItem.post.indexedAt }` } diff --git a/src/view/com/lists/ListMembers.tsx b/src/view/com/lists/ListMembers.tsx index 4a25c53e..e6afb3d3 100644 --- a/src/view/com/lists/ListMembers.tsx +++ b/src/view/com/lists/ListMembers.tsx @@ -215,7 +215,7 @@ export function ListMembers({ testID={testID ? `${testID}-flatlist` : undefined} ref={scrollElRef} data={items} - keyExtractor={(item: any) => item.uri || item._reactKey} + keyExtractor={(item: any) => item.subject?.did || item._reactKey} renderItem={renderItem} ListHeaderComponent={renderHeader} ListFooterComponent={Footer}