From db3b10e98b775bee48559bda5da3444a89437703 Mon Sep 17 00:00:00 2001 From: Hailey Date: Tue, 30 Jan 2024 17:09:02 -0800 Subject: [PATCH] update comment --- src/view/com/util/images/ImageLayoutGrid.tsx | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/view/com/util/images/ImageLayoutGrid.tsx b/src/view/com/util/images/ImageLayoutGrid.tsx index ad7a42af..ba6c04f5 100644 --- a/src/view/com/util/images/ImageLayoutGrid.tsx +++ b/src/view/com/util/images/ImageLayoutGrid.tsx @@ -89,14 +89,14 @@ function ImageLayoutGridInner(props: ImageLayoutGridInnerProps) { } } -// This is used to compute margins (rather than flexbox gap) due to Yoga bugs: +// On web we use margin to calculate gap, as aspectRatio does not properly size +// all images on web. On native though we cannot rely on margin, since the +// negative margin interferes with the swipe controls on pagers. // https://github.com/facebook/yoga/issues/1418 +// https://github.com/bluesky-social/social-app/issues/2601 const IMAGE_GAP = 5 const styles = StyleSheet.create({ - flexRow: {flexDirection: 'row', gap: !isWeb ? IMAGE_GAP : undefined}, - smallItem: {flex: 1, aspectRatio: 1}, - container: isWeb ? { marginHorizontal: -IMAGE_GAP / 2, @@ -105,6 +105,11 @@ const styles = StyleSheet.create({ : { gap: IMAGE_GAP, }, + flexRow: { + flexDirection: 'row', + gap: isWeb ? undefined : IMAGE_GAP, + }, + smallItem: {flex: 1, aspectRatio: 1}, image: isWeb ? { margin: IMAGE_GAP / 2,