From dfce190cb68603f98fd603ca85e8b39d94f584c0 Mon Sep 17 00:00:00 2001
From: dan <dan.abramov@gmail.com>
Date: Sun, 28 Apr 2024 22:52:40 +0100
Subject: [PATCH] [iOS] Fix selecting search input on focus (#3746)

* Select search text on focus

* Scope to iOS only
---
 src/view/screens/Search/Search.tsx | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/view/screens/Search/Search.tsx b/src/view/screens/Search/Search.tsx
index ee9e6943..9c148af5 100644
--- a/src/view/screens/Search/Search.tsx
+++ b/src/view/screens/Search/Search.tsx
@@ -25,7 +25,7 @@ import {NavigationProp} from '#/lib/routes/types'
 import {augmentSearchQuery} from '#/lib/strings/helpers'
 import {s} from '#/lib/styles'
 import {logger} from '#/logger'
-import {isNative, isWeb} from '#/platform/detection'
+import {isIOS, isNative, isWeb} from '#/platform/detection'
 import {listenSoftReset} from '#/state/events'
 import {useActorAutocompleteQuery} from '#/state/queries/actor-autocomplete'
 import {useActorSearch} from '#/state/queries/actor-search'
@@ -670,11 +670,11 @@ export function SearchScreen(
             ref={textInput}
             placeholder={_(msg`Search`)}
             placeholderTextColor={pal.colors.textLight}
-            selectTextOnFocus={isNative}
             returnKeyType="search"
             value={searchText}
             style={[pal.text, styles.headerSearchInput]}
             keyboardAppearance={theme.colorScheme}
+            selectTextOnFocus={isNative}
             onFocus={() => {
               if (isWeb) {
                 // Prevent a jump on iPad by ensuring that
@@ -684,6 +684,12 @@ export function SearchScreen(
                 })
               } else {
                 setShowAutocomplete(true)
+                if (isIOS) {
+                  // We rely on selectTextOnFocus, but it's broken on iOS:
+                  // https://github.com/facebook/react-native/issues/41988
+                  textInput.current?.setSelection(0, searchText.length)
+                  // We still rely on selectTextOnFocus for it to be instant on Android.
+                }
               }
             }}
             onChangeText={onChangeText}