From fef16e060f3931ed3e731ce228cfb14510a934a2 Mon Sep 17 00:00:00 2001 From: Paul Frazee Date: Thu, 6 Jun 2024 12:10:50 -0700 Subject: [PATCH] Fix notifications pagination on web (#4400) * Fix notifications pagination on web * Preserve larger threshold on native --- src/view/com/notifications/Feed.tsx | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/view/com/notifications/Feed.tsx b/src/view/com/notifications/Feed.tsx index e2f12e84..90f2785b 100644 --- a/src/view/com/notifications/Feed.tsx +++ b/src/view/com/notifications/Feed.tsx @@ -25,6 +25,7 @@ import {LoadMoreRetryBtn} from '#/view/com/util/LoadMoreRetryBtn' import {CenteredView} from '#/view/com/util/Views' import {FeedItem} from './FeedItem' import hairlineWidth = StyleSheet.hairlineWidth +import {isWeb} from '#/platform/detection' const EMPTY_FEED_ITEM = {_reactKey: '__empty__'} const LOAD_MORE_ERROR_ITEM = {_reactKey: '__load_more_error__'} @@ -182,7 +183,15 @@ export function Feed({ refreshing={isPTRing} onRefresh={onRefresh} onEndReached={onEndReached} - onEndReachedThreshold={2} + onEndReachedThreshold={ + /* + NOTE: + web's intersection observer struggles with the 2x threshold + and leads to missed pagination, so we keep it <1 + -prf + */ + isWeb ? 0.6 : 2 + } onScrolledDownChange={onScrolledDownChange} contentContainerStyle={s.contentContainer} // @ts-ignore our .web version only -prf