zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

[Statsig] Make gate checks lazily (#3594)

Browse source
This commit is contained in:
dan 2024-04-18 04:39:29 +01:00 • committed by GitHub
parent 086dc93a7a
commit 02becdf449
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
14 changed files with 67 additions and 62 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/view/com/util/List.tsx
View file

@ -40,8 +40,8 @@ function ListImpl<ItemT>(
const isScrolledDown = useSharedValue(false)
const contextScrollHandlers = useScrollHandlers()
const pal = usePalette('default')
const showsVerticalScrollIndicator =
!useGate('hide_vertical_scroll_indicators') || isWeb
const gate = useGate()
function handleScrolledDownChange(didScrollDown: boolean) {
onScrolledDownChange?.(didScrollDown)
}
@ -97,7 +97,9 @@ function ListImpl<ItemT>(
scrollEventThrottle={1}
style={style}
ref={ref}
showsVerticalScrollIndicator={showsVerticalScrollIndicator}
showsVerticalScrollIndicator={
isWeb || !gate('hide_vertical_scroll_indicators')
}
/>
)
}

7
src/view/com/util/Views.jsx
View file

@ -10,14 +10,11 @@ export function CenteredView(props) {
}
export function ScrollView(props) {
const showsVerticalScrollIndicator = !useGate(
'hide_vertical_scroll_indicators',
)
const gate = useGate()
return (
<Animated.ScrollView
{...props}
showsVerticalScrollIndicator={showsVerticalScrollIndicator}
showsVerticalScrollIndicator={!gate('hide_vertical_scroll_indicators')}
/>
)
}