zio
/
bsky-app
2
0
Fork 0
Code Pull Requests Packages Releases Activity

use greater of indexedAt or machine clock (#1182) 

* use greater of indexedAt or machine clock

* correct mobx usage
zio/stable
Eric Bailey 2023-08-15 17:18:35 -05:00 committed by GitHub
parent 6964382bad
commit 0576caae36
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/state/models/feeds/notifications.ts
View File

@ -241,6 +241,12 @@ export class NotificationsFeedModel {
loadMoreError = ''
hasMore = true
loadMoreCursor?: string
/**
* The last time notifications were seen. Refers to either the
* user's machine clock or the value of the `indexedAt` property on their
* latest notification, whichever was greater at the time of viewing.
*/
lastSync?: Date
// used to linearize async modifications to state
@ -327,9 +333,6 @@ export class NotificationsFeedModel {
limit: PAGE_SIZE,
})
await this._replaceAll(res)
runInAction(() => {
this.lastSync = new Date()
})
this._setQueued(undefined)
this._countUnread()
this._xIdle()
@ -523,9 +526,17 @@ export class NotificationsFeedModel {
// =
async _replaceAll(res: ListNotifications.Response) {
if (res.data.notifications[0]) {
this.mostRecentNotificationUri = res.data.notifications[0].uri
const latest = res.data.notifications[0]
if (latest) {
const now = new Date()
const lastIndexed = new Date(latest.indexedAt)
const nowOrLastIndexed = now > lastIndexed ? now : lastIndexed
this.mostRecentNotificationUri = latest.uri
this.lastSync = nowOrLastIndexed
}
return this._appendAll(res, true)
}