Remove overflow hidden from external link outer el (#5356)

* Remove overflow hidden

* Borders when no thumb

* Fix overflow, add bg to no-thumb state

* Cleanup
zio/dev^2
Eric Bailey 2024-09-15 15:42:45 -05:00 committed by GitHub
parent 42b28fec9d
commit 0681727b64
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 33 additions and 3 deletions

View File

@ -59,7 +59,7 @@ export const ExternalLinkEmbed = ({
}
return (
<View style={[a.flex_col, a.rounded_sm, a.overflow_hidden]}>
<View style={[a.flex_col, a.rounded_sm]}>
<LinkWrapper link={link} onOpen={onOpen} style={style}>
{imageUri && !embedPlayerParams ? (
<View>

View File

@ -227,8 +227,16 @@ export function ExternalPlayer({
<Animated.View
ref={viewRef}
collapsable={false}
style={[aspect, a.rounded_sm]}>
{link.thumb && (!isPlayerActive || isLoading) && (
style={[
aspect,
a.rounded_sm,
a.overflow_hidden,
{
borderBottomLeftRadius: 0,
borderBottomRightRadius: 0,
},
]}>
{link.thumb && (!isPlayerActive || isLoading) ? (
<>
<Image
style={[a.flex_1, styles.topRadius]}
@ -256,7 +264,29 @@ export function ExternalPlayer({
]}
/>
</>
) : (
<Fill
style={[
a.rounded_sm,
{
backgroundColor:
t.name === 'light' ? t.palette.contrast_975 : 'black',
borderBottomLeftRadius: 0,
borderBottomRightRadius: 0,
opacity: 0.3,
},
]}
/>
)}
<MediaInsetBorder
opaque
style={[
{
borderBottomLeftRadius: 0,
borderBottomRightRadius: 0,
},
]}
/>
<PlaceholderOverlay
isLoading={isLoading}
isPlayerActive={isPlayerActive}