zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

don't underline handle in post meta (#3591)

Browse source 
* alignment

remove the unnecessary styles now

seriously?

flex-end everything

flex shrink

test

test

rm unneeded flex

flex the text

don't underline handle in post meta

* use `paddingLeft`

* use `paddingLeft` but with `4`

* Fix overflow color

* Use nbsp to make mobile work

---------

Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
This commit is contained in:
Hailey 2024-04-17 19:09:10 -07:00 • committed by GitHub
parent 7e16276c04
commit 086dc93a7a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 43 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

39
src/view/com/util/Link.tsx
View file

@ -2,34 +2,35 @@ import React, {ComponentProps, memo, useMemo} from 'react'
import {
GestureResponderEvent,
Platform,
Pressable,
StyleProp,
TextStyle,
TextProps,
TextStyle,
TouchableOpacity,
View,
ViewStyle,
Pressable,
TouchableOpacity,
} from 'react-native'
import {useLinkProps, StackActions} from '@react-navigation/native'
import {Text} from './text/Text'
import {TypographyVariant} from 'lib/ThemeContext'
import {router} from '../../../routes'
import {sanitizeUrl} from '@braintree/sanitize-url'
import {StackActions, useLinkProps} from '@react-navigation/native'
import {useModalControls} from '#/state/modals'
import {useOpenLink} from '#/state/preferences/in-app-browser'
import {
DebouncedNavigationProp,
useNavigationDeduped,
} from 'lib/hooks/useNavigationDeduped'
import {
convertBskyAppUrlIfNeeded,
isExternalUrl,
linkRequiresWarning,
} from 'lib/strings/url-helpers'
import {TypographyVariant} from 'lib/ThemeContext'
import {isAndroid, isWeb} from 'platform/detection'
import {sanitizeUrl} from '@braintree/sanitize-url'
import {PressableWithHover} from './PressableWithHover'
import {useModalControls} from '#/state/modals'
import {useOpenLink} from '#/state/preferences/in-app-browser'
import {WebAuxClickWrapper} from 'view/com/util/WebAuxClickWrapper'
import {
DebouncedNavigationProp,
useNavigationDeduped,
} from 'lib/hooks/useNavigationDeduped'
import {useTheme} from '#/alf'
import {router} from '../../../routes'
import {PressableWithHover} from './PressableWithHover'
import {Text} from './text/Text'
type Event =
| React.MouseEvent<HTMLAnchorElement, MouseEvent>
@ -149,6 +150,7 @@ export const TextLink = memo(function TextLink({
onPress,
disableMismatchWarning,
navigationAction,
anchorNoUnderline,
...orgProps
}: {
testID?: string
@ -162,6 +164,7 @@ export const TextLink = memo(function TextLink({
title?: string
disableMismatchWarning?: boolean
navigationAction?: 'push' | 'replace' | 'navigate'
anchorNoUnderline?: boolean
} & TextProps) {
const {...props} = useLinkProps({to: sanitizeUrl(href)})
const navigation = useNavigationDeduped()
@ -172,6 +175,11 @@ export const TextLink = memo(function TextLink({
console.error('Unable to detect mismatching label')
}
if (anchorNoUnderline) {
dataSet = dataSet ?? {}
dataSet.noUnderline = 1
}
props.onPress = React.useCallback(
(e?: Event) => {
const requiresWarning =
@ -267,6 +275,7 @@ interface TextLinkOnWebOnlyProps extends TextProps {
navigationAction?: 'push' | 'replace' | 'navigate'
disableMismatchWarning?: boolean
onPointerEnter?: () => void
anchorNoUnderline?: boolean
}
export const TextLinkOnWebOnly = memo(function DesktopWebTextLink({
testID,