zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

[Session] Code cleanup (#3854)

Browse source 
* Split utils into files

* Move reducer to another file

* Write types explicitly

* Remove unnnecessary check

* Move things around a bit

* Move more stuff into agent factories

* Move more stuff into agent

* Fix gates await

* Clarify comments

* Enforce more via types

* Nit

* initSession -> resumeSession

* Protect against races

* Make agent opaque to reducer

* Check using plain condition
This commit is contained in:
dan 2024-05-08 03:30:55 +01:00 • committed by GitHub
parent 4fe5a869c3
commit 0910525e2e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 554 additions and 503 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/lib/hooks/useAccountSwitcher.ts
View file

@ -15,7 +15,7 @@ export function useAccountSwitcher() {
const [pendingDid, setPendingDid] = useState<string | null>(null)
const {_} = useLingui()
const {track} = useAnalytics()
const {initSession} = useSessionApi()
const {resumeSession} = useSessionApi()
const {requestSwitchToAccount} = useLoggedOutViewControls()
const onPressSwitchAccount = useCallback(
@ -39,7 +39,7 @@ export function useAccountSwitcher() {
// So we change the URL ourselves. The navigator will pick it up on remount.
history.pushState(null, '', '/')
}
await initSession(account)
await resumeSession(account)
logEvent('account:loggedIn', {logContext, withPassword: false})
Toast.show(_(msg`Signed in as @${account.handle}`))
} else {
@ -57,7 +57,7 @@ export function useAccountSwitcher() {
setPendingDid(null)
}
},
[_, track, initSession, requestSwitchToAccount, pendingDid],
[_, track, resumeSession, requestSwitchToAccount, pendingDid],
)
return {onPressSwitchAccount, pendingDid}