zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

show bottom bar on web tablet breakpoints when logged out (signup cta) (#2747)

Browse source 
* show signup bottom bar on web tablet

* show signup bottom bar on web tablet

* comment

* adjust load latest btn position based on logged in/out
This commit is contained in:
Hailey 2024-02-04 12:54:07 -08:00 • committed by GitHub
parent 250b48d5a2
commit 0bbe2c5e32
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 15 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/view/shell/createNativeStackNavigatorWithAuth.tsx
View file

@ -101,7 +101,7 @@ function NativeStackNavigator({
const onboardingState = useOnboardingState()
const {showLoggedOut} = useLoggedOutView()
const {setShowLoggedOut} = useLoggedOutViewControls()
const {isMobile} = useWebMediaQueries()
const {isMobile, isTabletOrMobile} = useWebMediaQueries()
if ((!PWI_ENABLED || activeRouteRequiresAuth) && !hasSession) {
return <LoggedOut />
}
@ -134,6 +134,10 @@ function NativeStackNavigator({
}
}
// Show the bottom bar if we have a session only on mobile web. If we don't have a session, we want to show it
// on both tablet and mobile web so that we see the sign up CTA.
const showBottomBar = hasSession ? isMobile : isTabletOrMobile
return (
<NavigationContent>
<NativeStackView
@ -142,8 +146,8 @@ function NativeStackNavigator({
navigation={navigation}
descriptors={newDescriptors}
/>
{isWeb && isMobile && <BottomBarWeb />}
{isWeb && !isMobile && (
{isWeb && showBottomBar && <BottomBarWeb />}
{isWeb && !showBottomBar && (
<>
<DesktopLeftNav />
<DesktopRightNav routeName={activeRoute.name} />