Fix reactivity of dialogs (Dialogs Pt. 1) (#3146)
* Improve a11y on ios * Format * Remove android * Fix android * Revert some changes * use sharedvalue for `importantForAccessibility` * add back `isOpen` * fix some more types --------- Co-authored-by: Eric Bailey <git@esb.lol>
This commit is contained in:
parent
8f623c3bdf
commit
0f9f08b1ef
4 changed files with 49 additions and 38 deletions
|
@ -21,8 +21,7 @@ export function useDialogControl(): DialogOuterProps['control'] {
|
|||
open: () => {},
|
||||
close: () => {},
|
||||
})
|
||||
const {activeDialogs, openDialogs} = useDialogStateContext()
|
||||
const isOpen = openDialogs.includes(id)
|
||||
const {activeDialogs} = useDialogStateContext()
|
||||
|
||||
React.useEffect(() => {
|
||||
activeDialogs.current.set(id, control)
|
||||
|
@ -36,7 +35,6 @@ export function useDialogControl(): DialogOuterProps['control'] {
|
|||
() => ({
|
||||
id,
|
||||
ref: control,
|
||||
isOpen,
|
||||
open: () => {
|
||||
control.current.open()
|
||||
},
|
||||
|
@ -44,6 +42,6 @@ export function useDialogControl(): DialogOuterProps['control'] {
|
|||
control.current.close(cb)
|
||||
},
|
||||
}),
|
||||
[id, control, isOpen],
|
||||
[id, control],
|
||||
)
|
||||
}
|
||||
|
|
|
@ -22,7 +22,7 @@ export type DialogControlRefProps = {
|
|||
export type DialogControlProps = DialogControlRefProps & {
|
||||
id: string
|
||||
ref: React.RefObject<DialogControlRefProps>
|
||||
isOpen: boolean
|
||||
isOpen?: boolean
|
||||
}
|
||||
|
||||
export type DialogContextProps = {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue