zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

Handle push notifications for DMs (#3895)

Browse source 
* add some better handling for notifications

prep merge

move `useNotificationsListener` into shell

progress

better structure

only show messages notifications while using app if it is the current account

progress

only emit on native

current chat emitter

only show alerts for the current chat

type

add logs

setup handlers

* remove event emitter

* just needs cleanup

* oops

* remove unnecessary `queryClient` param

* few fixes

* cleanup

* nit

* remove folds

* remove comment

* simplify if

* add back invalidate

* comment out other navigations for now

* rename type

* handle various navigation cases

* push to conversation from notification

* update badge in all cases except `chat-message`

* ensure no duplicate notifications

* rm unused `animationOnReplace`

* revert to using `goBack` in the conversation header

* add todo comment
This commit is contained in:
Hailey 2024-05-09 10:04:05 -07:00 • committed by GitHub
parent 1341845537
commit 17e3b946cb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 274 additions and 109 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/screens/Messages/Conversation/index.tsx
View file

@ -110,7 +110,7 @@ let Header = ({
if (isWeb) {
navigation.replace('Messages')
} else {
navigation.pop()
navigation.goBack()
}
}, [navigation])

16
src/screens/Messages/List/index.tsx
View file

@ -40,11 +40,12 @@ import {ClipClopGate} from '../gate'
import {useDmServiceUrlStorage} from '../Temp/useDmServiceUrlStorage'
type Props = NativeStackScreenProps<MessagesTabNavigatorParams, 'Messages'>
export function MessagesScreen({navigation}: Props) {
export function MessagesScreen({navigation, route}: Props) {
const {_} = useLingui()
const t = useTheme()
const newChatControl = useDialogControl()
const {gtMobile} = useBreakpoints()
const pushToConversation = route.params?.pushToConversation
// TEMP
const {serviceUrl, setServiceUrl} = useDmServiceUrlStorage()
@ -57,6 +58,19 @@ export function MessagesScreen({navigation}: Props) {
)
}, [serviceUrl])
// Whenever we have `pushToConversation` set, it means we pressed a notification for a chat without being on
// this tab. We should immediately push to the conversation after pressing the notification.
// After we push, reset with `setParams` so that this effect will fire next time we press a notification, even if
// the conversation is the same as before
React.useEffect(() => {
if (pushToConversation) {
navigation.navigate('MessagesConversation', {
conversation: pushToConversation,
})
navigation.setParams({pushToConversation: undefined})
}
}, [navigation, pushToConversation])
const renderButton = useCallback(() => {
return (
<Link