zio
/
bsky-app
2
0
Fork 0
Code Pull Requests Packages Releases Activity

Increase hit slop for web's app language picker (#3535) 

* fix: make app language picker tap region larger

* fix: add right padding on drawer signup card

noticeable on portuguese language

* fix: mimic hitSlop
zio/stable
Mary 2024-04-14 02:02:22 +07:00 committed by GitHub
parent a8c1e71907
commit 196dd3a8ab
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/components/AppLanguageDropdown.web.tsx
View File

@ -29,7 +29,16 @@ export function AppLanguageDropdown() {
) )
return ( return (
<View style={[a.flex_row, a.gap_sm, a.align_center, a.flex_shrink]}> <View
style={[
// We don't have hitSlop here to increase the tap region,
// alternative is negative margins.
{height: 32, marginVertical: -((32 - 14) / 2)},
a.flex_row,
a.gap_sm,
a.align_center,
a.flex_shrink,
]}>
<Text aria-hidden={true} style={t.atoms.text_contrast_medium}> <Text aria-hidden={true} style={t.atoms.text_contrast_medium}>
{APP_LANGUAGES.find(l => l.code2 === sanitizedLang)?.name} {APP_LANGUAGES.find(l => l.code2 === sanitizedLang)?.name}
</Text> </Text>

2
src/view/shell/Drawer.tsx
View File

@ -224,7 +224,9 @@ let DrawerContent = ({}: {}): React.ReactNode => {
/> />
</View> </View>
) : ( ) : (
<View style={{paddingRight: 20}}>
<NavSignupCard /> <NavSignupCard />
</View>
)} )}
{hasSession ? ( {hasSession ? (