zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

Fix some useEffect() cleanup issues

Browse source
This commit is contained in:
Paul Frazee 2022-10-26 14:48:15 -05:00
parent 1983512fef
commit 1ab8285ad3
6 changed files with 38 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/view/screens/Notifications.tsx
View file

@ -13,6 +13,7 @@ export const Notifications = ({visible}: ScreenParams) => {
const store = useStores()
useEffect(() => {
let aborted = false
if (!visible) {
return
}
@ -24,7 +25,13 @@ export const Notifications = ({visible}: ScreenParams) => {
console.log('Fetching notifications feed')
const newNotesView = new NotificationsViewModel(store, {})
setNotesView(newNotesView)
newNotesView.setup().then(() => setHasSetup(true))
newNotesView.setup().then(() => {
if (aborted) return
setHasSetup(true)
})
}
return () => {
aborted = true
}
}, [visible, store])