[Video] Open the floodgates (partially) (#5208)

zio/stable
Samuel Newman 2024-09-07 20:15:15 +01:00 committed by GitHub
parent 51259e7c42
commit 1b4fee3e43
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 1 additions and 29 deletions

View File

@ -2,6 +2,5 @@ export type Gate =
// Keep this alphabetic please. // Keep this alphabetic please.
| 'debug_show_feedcontext' | 'debug_show_feedcontext'
| 'suggested_feeds_interstitial' | 'suggested_feeds_interstitial'
| 'video_debug' // not recommended
| 'video_upload' // upload videos | 'video_upload' // upload videos
| 'video_view_on_posts' // see posted videos | 'video_view_on_posts' // see posted videos

View File

@ -1,4 +1,4 @@
import React, {memo, useId, useMemo, useState} from 'react' import React, {memo, useMemo, useState} from 'react'
import {StyleSheet, View} from 'react-native' import {StyleSheet, View} from 'react-native'
import { import {
AppBskyActorDefs, AppBskyActorDefs,
@ -21,7 +21,6 @@ import {isReasonFeedSource, ReasonFeedSource} from '#/lib/api/feed/types'
import {MAX_POST_LINES} from '#/lib/constants' import {MAX_POST_LINES} from '#/lib/constants'
import {usePalette} from '#/lib/hooks/usePalette' import {usePalette} from '#/lib/hooks/usePalette'
import {makeProfileLink} from '#/lib/routes/links' import {makeProfileLink} from '#/lib/routes/links'
import {useGate} from '#/lib/statsig/statsig'
import {sanitizeDisplayName} from '#/lib/strings/display-names' import {sanitizeDisplayName} from '#/lib/strings/display-names'
import {sanitizeHandle} from '#/lib/strings/handles' import {sanitizeHandle} from '#/lib/strings/handles'
import {countLines} from '#/lib/strings/helpers' import {countLines} from '#/lib/strings/helpers'
@ -47,7 +46,6 @@ import {AppModerationCause} from '#/components/Pills'
import {ProfileHoverCard} from '#/components/ProfileHoverCard' import {ProfileHoverCard} from '#/components/ProfileHoverCard'
import {RichText} from '#/components/RichText' import {RichText} from '#/components/RichText'
import {Link, TextLink, TextLinkOnWebOnly} from '../util/Link' import {Link, TextLink, TextLinkOnWebOnly} from '../util/Link'
import {VideoEmbed} from '../util/post-embeds/VideoEmbed'
import {AviFollowButton} from './AviFollowButton' import {AviFollowButton} from './AviFollowButton'
interface FeedItemProps { interface FeedItemProps {
@ -386,7 +384,6 @@ let FeedItemInner = ({
post={post} post={post}
threadgateRecord={threadgateRecord} threadgateRecord={threadgateRecord}
/> />
<VideoDebug />
<PostCtrls <PostCtrls
post={post} post={post}
record={record} record={record}
@ -564,23 +561,6 @@ function ReplyToLabel({
) )
} }
function VideoDebug() {
const gate = useGate()
const id = useId()
if (!gate('video_debug')) return null
return (
<VideoEmbed
embed={{
playlist: `https://lumi.jazco.dev/watch/did:plc:q6gjnaw2blty4crticxkmujt/Qmc8w93UpTa2adJHg4ZhnDPrBs1EsbzrekzPcqF5SwusuZ/playlist.m3u8?ignore_me_just_testing_frontend_stuff=${id}`,
cid: 'Qmc8w93UpTa2adJHg4ZhnDPrBs1EsbzrekzPcqF5SwusuZ',
aspectRatio: {height: 9, width: 16},
}}
/>
)
}
const styles = StyleSheet.create({ const styles = StyleSheet.create({
outer: { outer: {
paddingLeft: 10, paddingLeft: 10,

View File

@ -7,7 +7,6 @@ import {msg, Trans} from '@lingui/macro'
import {useLingui} from '@lingui/react' import {useLingui} from '@lingui/react'
import {clamp} from '#/lib/numbers' import {clamp} from '#/lib/numbers'
import {useGate} from '#/lib/statsig/statsig'
import {useAutoplayDisabled} from 'state/preferences' import {useAutoplayDisabled} from 'state/preferences'
import {VideoEmbedInnerNative} from '#/view/com/util/post-embeds/VideoEmbedInner/VideoEmbedInnerNative' import {VideoEmbedInnerNative} from '#/view/com/util/post-embeds/VideoEmbedInner/VideoEmbedInnerNative'
import {atoms as a} from '#/alf' import {atoms as a} from '#/alf'
@ -24,8 +23,6 @@ interface Props {
} }
export function VideoEmbed({embed}: Props) { export function VideoEmbed({embed}: Props) {
const gate = useGate()
const [key, setKey] = useState(0) const [key, setKey] = useState(0)
const renderError = useCallback( const renderError = useCallback(
@ -42,10 +39,6 @@ export function VideoEmbed({embed}: Props) {
aspectRatio = clamp(aspectRatio, 1 / 1, 3 / 1) aspectRatio = clamp(aspectRatio, 1 / 1, 3 / 1)
} }
if (!gate('video_view_on_posts')) {
return null
}
return ( return (
<View <View
style={[ style={[