zio
/
bsky-app
2
0
Fork 0
Code Pull Requests Packages Releases Activity

Allow all encoding for hashtags in URL (#3131)

zio/stable
Hailey 2024-03-07 09:04:02 -08:00 committed by GitHub
parent 8b0e575f64
commit 1cf49517b5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/components/TagMenu/index.tsx
View File

@ -98,7 +98,7 @@ export function TagMenu({
control.close(() => { control.close(() => {
navigation.push('Hashtag', { navigation.push('Hashtag', {
tag: tag.replaceAll('#', '%23'), tag: encodeURIComponent(tag),
}) })
}) })
@ -153,7 +153,7 @@ export function TagMenu({
control.close(() => { control.close(() => {
navigation.push('Hashtag', { navigation.push('Hashtag', {
tag: tag.replaceAll('#', '%23'), tag: encodeURIComponent(tag),
author: authorHandle, author: authorHandle,
}) })
}) })

4
src/components/TagMenu/index.web.tsx
View File

@ -66,7 +66,7 @@ export function TagMenu({
label: _(msg`See ${truncatedTag} posts`), label: _(msg`See ${truncatedTag} posts`),
onPress() { onPress() {
navigation.push('Hashtag', { navigation.push('Hashtag', {
tag: tag.replaceAll('#', '%23'), tag: encodeURIComponent(tag),
}) })
}, },
testID: 'tagMenuSearch', testID: 'tagMenuSearch',
@ -83,7 +83,7 @@ export function TagMenu({
label: _(msg`See ${truncatedTag} posts by user`), label: _(msg`See ${truncatedTag} posts by user`),
onPress() { onPress() {
navigation.push('Hashtag', { navigation.push('Hashtag', {
tag: tag.replaceAll('#', '%23'), tag: encodeURIComponent(tag),
author: authorHandle, author: authorHandle,
}) })
}, },

4
src/screens/Hashtag.tsx
View File

@ -42,7 +42,7 @@ export default function HashtagScreen({
const [isPTR, setIsPTR] = React.useState(false) const [isPTR, setIsPTR] = React.useState(false)
const fullTag = React.useMemo(() => { const fullTag = React.useMemo(() => {
return `#${tag.replaceAll('%23', '#')}` return `#${decodeURIComponent(tag)}`
}, [tag]) }, [tag])
const queryParam = React.useMemo(() => { const queryParam = React.useMemo(() => {
@ -83,7 +83,7 @@ export default function HashtagScreen({
const onShare = React.useCallback(() => { const onShare = React.useCallback(() => {
const url = new URL('https://bsky.app') const url = new URL('https://bsky.app')
url.pathname = `/hashtag/${tag}` url.pathname = `/hashtag/${decodeURIComponent(tag)}`
if (author) { if (author) {
url.searchParams.set('author', author) url.searchParams.set('author', author)
} }