zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

Fix error screen on native, use Not Found for profile errors instead of Oops! (#2789)

Browse source 
* remove unnecessary `<CenterView>`

* show back header on profile error

* use `Not Found` instead of `Oops` for account errors

* use `Not Found` instead of `Oops` for account errors
This commit is contained in:
Hailey 2024-02-08 12:01:36 -08:00 • committed by GitHub
parent 4041db31e2
commit 1de1d10cf6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 69 additions and 62 deletions
Download patch file Download diff file Expand all files Collapse all files

31
src/view/screens/Profile.tsx
View file

@ -50,6 +50,7 @@ interface SectionRef {
type Props = NativeStackScreenProps<CommonNavigatorParams, 'Profile'>
export function ProfileScreen({route}: Props) {
const {_} = useLingui()
const {currentAccount} = useSession()
const name =
route.params.name === 'me' ? currentAccount?.did : route.params.name
@ -97,14 +98,13 @@ export function ProfileScreen({route}: Props) {
}
if (resolveError || profileError) {
return (
<CenteredView>
<ErrorScreen
testID="profileErrorScreen"
title="Oops!"
message={cleanError(resolveError || profileError)}
onPressTryAgain={onPressTryAgain}
/>
</CenteredView>
<ErrorScreen
testID="profileErrorScreen"
title={profileError ? _(msg`Not Found`) : _(msg`Oops!`)}
message={cleanError(resolveError || profileError)}
onPressTryAgain={onPressTryAgain}
showHeader
/>
)
}
if (profile && moderationOpts) {
@ -118,14 +118,13 @@ export function ProfileScreen({route}: Props) {
}
// should never happen
return (
<CenteredView>
<ErrorScreen
testID="profileErrorScreen"
title="Oops!"
message="Something went wrong and we're not sure what."
onPressTryAgain={onPressTryAgain}
/>
</CenteredView>
<ErrorScreen
testID="profileErrorScreen"
title="Oops!"
message="Something went wrong and we're not sure what."
onPressTryAgain={onPressTryAgain}
showHeader
/>
)
}