Merge branch 'main' of github.com:bluesky-social/social-app into main

src/locale/helpers.ts

@@ -119,8 +119,9 @@ export function sanitizeAppLanguageSetting(appLanguage: string): AppLanguage {
       // DISABLED until this translation is fixed -prf
       // case 'de':
       //   return AppLanguage.de
-      case 'es':
+      // DISABLED until this translation is more thoroughly reviewed -prf
-        return AppLanguage.es
+      // case 'es':
+      //   return AppLanguage.es
       default:
         continue
     }

src/locale/i18n.ts

@@ -8,7 +8,8 @@ import {messages as messagesJa} from '#/locale/locales/ja/messages'
 import {messages as messagesFr} from '#/locale/locales/fr/messages'
 // DISABLED until this translation is fixed -prf
 // import {messages as messagesDe} from '#/locale/locales/de/messages'
-import {messages as messagesEs} from '#/locale/locales/es/messages'
+// DISABLED until this translation is more thoroughly reviewed -prf
+// import {messages as messagesEs} from '#/locale/locales/es/messages'
 
 import {sanitizeAppLanguageSetting} from '#/locale/helpers'
 import {AppLanguage} from '#/locale/languages'
@@ -35,10 +36,11 @@ export async function dynamicActivate(locale: AppLanguage) {
     //   i18n.loadAndActivate({locale, messages: messagesDe})
     //   break
     // }
-    case AppLanguage.es: {
+    // DISABLED until this translation is more thoroughly reviewed -prf
-      i18n.loadAndActivate({locale, messages: messagesEs})
+    // case AppLanguage.es: {
-      break
+    //   i18n.loadAndActivate({locale, messages: messagesEs})
-    }
+    //   break
+    // }
     default: {
       i18n.loadAndActivate({locale, messages: messagesEn})
       break

src/locale/i18n.web.ts

@@ -29,10 +29,11 @@ export async function dynamicActivate(locale: AppLanguage) {
     //   mod = await import(`./locales/de/messages`)
     //   break
     // }
-    case AppLanguage.es: {
+    // DISABLED until this translation is more thoroughly reviewed -prf
-      mod = await import(`./locales/es/messages`)
+    // case AppLanguage.es: {
-      break
+    //   mod = await import(`./locales/es/messages`)
-    }
+    //   break
+    // }
     default: {
       mod = await import(`./locales/en/messages`)
       break

src/locale/languages.ts

@@ -11,7 +11,8 @@ export enum AppLanguage {
   fr = 'fr',
   // DISABLED until this translation is fixed -prf
   // de = 'de',
-  es = 'es',
+  // DISABLED until this translation is more thoroughly reviewed -prf
+  // es = 'es',
 }
 
 interface AppLanguageConfig {
@@ -26,7 +27,8 @@ export const APP_LANGUAGES: AppLanguageConfig[] = [
   {code2: AppLanguage.fr, name: 'Français'},
   // DISABLED until this translation is fixed -prf
   // {code2: AppLanguage.de, name: 'Deutsch'},
-  {code2: AppLanguage.es, name: 'Español'},
+  // DISABLED until this translation is more thoroughly reviewed -prf
+  // {code2: AppLanguage.es, name: 'Español'},
 ]
 
 export const LANGUAGES: Language[] = [

src/view/com/util/forms/SearchInput.tsx

@@ -11,6 +11,7 @@ import {
   FontAwesomeIcon,
   FontAwesomeIconStyle,
 } from '@fortawesome/react-native-fontawesome'
+import {HITSLOP_10} from 'lib/constants'
 import {MagnifyingGlassIcon} from 'lib/icons'
 import {useTheme} from 'lib/ThemeContext'
 import {usePalette} from 'lib/hooks/usePalette'
@@ -71,7 +72,8 @@ export function SearchInput({
           onPress={onPressCancelSearchInner}
           accessibilityRole="button"
           accessibilityLabel={_(msg`Clear search query`)}
-          accessibilityHint="">
+          accessibilityHint=""
+          hitSlop={HITSLOP_10}>
           <FontAwesomeIcon
             icon="xmark"
             size={16}

src/view/screens/Feeds.tsx

@@ -494,6 +494,8 @@ export function FeedsScreen(_props: Props) {
         // @ts-ignore our .web version only -prf
         desktopFixedHeight
         scrollIndicatorInsets={{right: 1}}
+        keyboardShouldPersistTaps="handled"
+        keyboardDismissMode="on-drag"
       />
 
       {hasSession && (

src/view/screens/Search/Search.tsx

@@ -162,6 +162,8 @@ function SearchScreenSuggestedFollows() {
       // @ts-ignore web only -prf
       desktopFixedHeight
       contentContainerStyle={{paddingBottom: 1200}}
+      keyboardShouldPersistTaps="handled"
+      keyboardDismissMode="on-drag"
     />
   ) : (
     <CenteredView sideBorders style={[pal.border, s.hContentRegion]}>
@@ -578,7 +580,8 @@ export function SearchScreen(
               onPress={onPressClearQuery}
               accessibilityRole="button"
               accessibilityLabel={_(msg`Clear search query`)}
-              accessibilityHint="">
+              accessibilityHint=""
+              hitSlop={HITSLOP_10}>
               <FontAwesomeIcon
                 icon="xmark"
                 size={16}
@@ -590,7 +593,10 @@ export function SearchScreen(
 
         {query || inputIsFocused ? (
           <View style={styles.headerCancelBtn}>
-            <Pressable onPress={onPressCancelSearch} accessibilityRole="button">
+            <Pressable
+              onPress={onPressCancelSearch}
+              accessibilityRole="button"
+              hitSlop={HITSLOP_10}>
               <Text style={[pal.text]}>
                 <Trans>Cancel</Trans>
               </Text>
@@ -604,7 +610,11 @@ export function SearchScreen(
           {isFetching ? (
             <Loader />
           ) : (
-            <ScrollView style={{height: '100%'}} dataSet={{stableGutters: '1'}}>
+            <ScrollView
+              style={{height: '100%'}}
+              dataSet={{stableGutters: '1'}}
+              keyboardShouldPersistTaps="handled"
+              keyboardDismissMode="on-drag">
               {searchResults.length ? (
                 searchResults.map((item, i) => (
                   <SearchResultCard