zio
/
bsky-app
2
0
Fork 0
Code Pull Requests Packages Releases Activity

Only show replies in Following if following all involved actors (#4869) 

* Only show replies in Following for followed root and grandparent

* Remove now-unnecessary check

* Simplify condition
zio/stable
dan 2024-08-02 17:13:31 +01:00 committed by GitHub
parent 7f292abf51
commit 293ac6fab2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 17 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
src/lib/api/feed-manip.ts
View File

@ -82,10 +82,6 @@ export class FeedViewPostsSlice {
return AppBskyFeedDefs.isReasonRepost(reason) return AppBskyFeedDefs.isReasonRepost(reason)
} }
get includesThreadRoot() {
return !this.items[0].reply
}
get likeCount() { get likeCount() {
return this._feedPost.post.likeCount ?? 0 return this._feedPost.post.likeCount ?? 0
} }
@ -119,20 +115,19 @@ export class FeedViewPostsSlice {
isFollowingAllAuthors(userDid: string) { isFollowingAllAuthors(userDid: string) {
const feedPost = this._feedPost const feedPost = this._feedPost
if (feedPost.post.author.did === userDid) { const authors = [feedPost.post.author]
return true if (feedPost.reply) {
} if (AppBskyFeedDefs.isPostView(feedPost.reply.parent)) {
if (AppBskyFeedDefs.isPostView(feedPost.reply?.parent)) { authors.push(feedPost.reply.parent.author)
const parent = feedPost.reply?.parent }
if (parent?.author.did === userDid) { if (feedPost.reply.grandparentAuthor) {
return true authors.push(feedPost.reply.grandparentAuthor)
}
if (AppBskyFeedDefs.isPostView(feedPost.reply.root)) {
authors.push(feedPost.reply.root.author)
} }
return (
parent?.author.viewer?.following &&
feedPost.post.author.viewer?.following
)
} }
return false return authors.every(a => a.did === userDid || a.viewer?.following)
} }
} }
@ -304,19 +299,14 @@ export class FeedTuner {
tuner: FeedTuner, tuner: FeedTuner,
slices: FeedViewPostsSlice[], slices: FeedViewPostsSlice[],
): FeedViewPostsSlice[] => { ): FeedViewPostsSlice[] => {
// remove any replies without at least minLikes likes
for (let i = slices.length - 1; i >= 0; i--) { for (let i = slices.length - 1; i >= 0; i--) {
const slice = slices[i] const slice = slices[i]
if (slice.isReply) { if (
if (slice.isThread && slice.includesThreadRoot) { slice.isReply &&
continue !slice.isRepost &&
} !slice.isFollowingAllAuthors(userDid)
if (slice.isRepost) { ) {
continue slices.splice(i, 1)
}
if (!slice.isFollowingAllAuthors(userDid)) {
slices.splice(i, 1)
}
} }
} }
return slices return slices