zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

Remove dangerous derived state from RichText (#3007)

Browse source 
* Remove facet resolution from RichText

* Remove derived state
This commit is contained in:
dan 2024-02-28 01:35:25 +00:00 • committed by GitHub
parent 603f3c0be9
commit 2d14d0e2db
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/view/screens/Storybook/Typography.tsx
View file

@ -22,12 +22,14 @@ export function Typography() {
<Text style={[a.text_2xs]}>atoms.text_2xs</Text>
<RichText
resolveFacets
// TODO: This only supports already resolved facets.
// Resolving them on read is bad anyway.
value={`This is rich text. It can have mentions like @bsky.app or links like https://bsky.social`}
/>
<RichText
selectable
resolveFacets
// TODO: This only supports already resolved facets.
// Resolving them on read is bad anyway.
value={`This is rich text. It can have mentions like @bsky.app or links like https://bsky.social`}
style={[a.text_xl]}
/>