Set keyboardDismisMode to interactive on the report dialog (#3288)

zio/stable
Paul Frazee 2024-03-19 20:21:25 -07:00 committed by GitHub
parent b6c9d34e45
commit 2e2fae378a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 16 additions and 4 deletions

View File

@ -206,12 +206,16 @@ export function Inner({children, style}: DialogInnerProps) {
)
}
export function ScrollableInner({children, style}: DialogInnerProps) {
export function ScrollableInner({
children,
keyboardDismissMode,
style,
}: DialogInnerProps) {
const insets = useSafeAreaInsets()
return (
<BottomSheetScrollView
keyboardShouldPersistTaps="handled"
keyboardDismissMode="on-drag"
keyboardDismissMode={keyboardDismissMode || 'on-drag'}
style={[
a.flex_1, // main diff is this
a.p_xl,

View File

@ -1,5 +1,9 @@
import React from 'react'
import type {AccessibilityProps, GestureResponderEvent} from 'react-native'
import type {
AccessibilityProps,
GestureResponderEvent,
ScrollViewProps,
} from 'react-native'
import {BottomSheetProps} from '@gorhom/bottom-sheet'
import {ViewStyleProp} from '#/alf'
@ -61,9 +65,11 @@ export type DialogInnerProps =
label?: undefined
accessibilityLabelledBy: A11yProps['aria-labelledby']
accessibilityDescribedBy: string
keyboardDismissMode?: ScrollViewProps['keyboardDismissMode']
}>
| DialogInnerPropsBase<{
label: string
accessibilityLabelledBy?: undefined
accessibilityDescribedBy?: undefined
keyboardDismissMode?: ScrollViewProps['keyboardDismissMode']
}>

View File

@ -37,7 +37,9 @@ function ReportDialogInner(props: ReportDialogProps) {
const isLoading = useDelayedLoading(500, isLabelerLoading)
return (
<Dialog.ScrollableInner label="Report Dialog">
<Dialog.ScrollableInner
label="Report Dialog"
keyboardDismissMode="interactive">
{isLoading ? (
<View style={[a.align_center, {height: 100}]}>
<Loader size="xl" />