zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

[Embeds] stop adding tracking params to non-bsky.app links (#4167)

Browse source 
* don't add tracking params on non-bsky.app links

* validate facets
This commit is contained in:
Samuel Newman 2024-05-23 03:52:46 +01:00 • committed by GitHub
parent 69f4684859
commit 334483ad9a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 37 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

5
bskyembed/src/components/embed.tsx
View file

@ -193,7 +193,7 @@ export function Embed({
function Info({children}: {children: ComponentChildren}) {
return (
<div className="w-full rounded-lg border py-2 px-2.5 flex-row flex gap-2 bg-neutral-50">
<img src={infoIcon as string} className="w-4 h-4 shrink-0 mt-0.5" />
<img src={infoIcon} className="w-4 h-4 shrink-0 mt-0.5" />
<p className="text-sm text-textLight">{children}</p>
</div>
)
@ -293,7 +293,8 @@ function ExternalEmbed({
return (
<Link
href={content.external.uri}
className="w-full rounded-lg overflow-hidden border flex flex-col items-stretch">
className="w-full rounded-lg overflow-hidden border flex flex-col items-stretch"
disableTracking>
{content.external.thumb && (
<img
src={content.external.thumb}